Vwwxrf

Was any UN Security Council vote triple-vetoed?

Replacing matching entries in one column of a file by another column from a different file

Two films in a tank, only one comes out with a development error – why?

Has there ever been an airliner design involving reducing generator load by installing solar panels?

Mortgage Pre-approval / Loan - Apply Alone or with Fiancée?

How to regain access to running applications after accidentally zapping X.org?

Uncaught TypeError: 'set' on proxy: trap returned falsish for property Name

Filter any system log file by date or date range

Why doesn't H₄O²⁺ exist?

Cross compiling for RPi - error while loading shared libraries

What typically incentivizes a professor to change jobs to a lower ranking university?

Accidentally leaked the solution to an assignment, what to do now? (I'm the prof)

How can I prevent hyper evolved versions of regular creatures from wiping out their cousins?

How to format long polynomial?

What does "Puller Prush Person" mean?

Is it possible to do 50 km distance without any previous training?

meaning of に in 本当に?

Why can't we play rap on piano?

How is it possible to have an ability score that is less than 3?

Alternative to sending password over mail?

How to move a thin line with the black arrow in Illustrator?

Is it legal for company to use my work email to pretend I still work there?

DC-DC converter from low voltage at high current, to high voltage at low current

Roll the carpet

Correctness of C++14 static initialization ordering technique?

Static Multilevel Inheritance with CRTP (Fast Intrusive Pointers)Instance depth ordering systemSingleton as static instanceA classy wine collection - Construction vs. InitializationAn implementation of a static any typeA polymorphic callable wrapper for any callableArray whose first element is arbitralily indexed – writing a container wrapperStatic Batch file AnalyserGenerators and Distributions 2.0Recursive data-types, binary tree, list-initialization

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;

0

$begingroup$

I have inherited legacy code containing static initialization order problems:

// A.hpp
class A
public:
 static A A1;
 A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;

This fails when MY_FAVORITE_A is initialized before A::A1.

I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?

// A.h
class A
public:
 static A A1;
 A(...);
private:
 class Initializer 
 public:
 Initializer();
 
;

namespace 
 int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

 static A::Initializer initializer;
 return 0;


A::Initializer::Initializer()

 A::A1 = A(...);

B.cpp is unchanged.

c++ c++14

share|improve this question

edited 2 mins ago

kevin cline

asked 58 mins ago

kevin clinekevin cline

32516

$endgroup$

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
  $endgroup$
  – pacmaninbw
  23 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
  $endgroup$
  – kevin cline
  9 mins ago
  
  

  
  
  
  

add a comment | 

0

$begingroup$

I have inherited legacy code containing static initialization order problems:

// A.hpp
class A
public:
 static A A1;
 A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;

This fails when MY_FAVORITE_A is initialized before A::A1.

I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?

// A.h
class A
public:
 static A A1;
 A(...);
private:
 class Initializer 
 public:
 Initializer();
 
;

namespace 
 int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

 static A::Initializer initializer;
 return 0;


A::Initializer::Initializer()

 A::A1 = A(...);

B.cpp is unchanged.

c++ c++14

share|improve this question

edited 2 mins ago

kevin cline

asked 58 mins ago

kevin clinekevin cline

32516

$endgroup$

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  This seems to be off topic, perhaps rewording the question would help. Please see How to as a good question at codereview.stackexchange.com/help/how-to-ask
  $endgroup$
  – pacmaninbw
  23 mins ago
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  From the referenced page: "If you have a working piece of code from your project and are looking for open-ended feedback in the following areas: ... Application of best practices and design pattern usage / Correctness in unanticipated cases" The code is working. I have removed the irrelevant domain-specific details. I'm seeking a review for correctness.
  $endgroup$
  – kevin cline
  9 mins ago
  
  

  
  
  
  

add a comment | 

$begingroup$

I have inherited legacy code containing static initialization order problems:

// A.hpp
class A
public:
 static A A1;
 A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;

This fails when MY_FAVORITE_A is initialized before A::A1.

I'm trying to ensure that they are initialized in the proper order without replacing A::A1 with a function. Here's the modified code. Will it work reliably?

// A.h
class A
public:
 static A A1;
 A(...);
private:
 class Initializer 
 public:
 Initializer();
 
;

namespace 
 int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

 static A::Initializer initializer;
 return 0;


A::Initializer::Initializer()

 A::A1 = A(...);

B.cpp is unchanged.

c++ c++14

share|improve this question

edited 2 mins ago

kevin cline

asked 58 mins ago

kevin clinekevin cline

32516

$endgroup$

// A.hpp
class A
public:
 static A A1;
 A(...);
;

// A.cpp
A A::A1(...);

// B.cpp
#include "A.hpp"
A MY_FAVORITE_A = A::A1;

// A.h
class A
public:
 static A A1;
 A(...);
private:
 class Initializer 
 public:
 Initializer();
 
;

namespace 
 int a_initializer = A::initialize_statics();


// A.cpp
A MY_FAVORITE_A;

A::initialize_statics()

 static A::Initializer initializer;
 return 0;


A::Initializer::Initializer()

 A::A1 = A(...);

share|improve this question

edited 2 mins ago

kevin cline

asked 58 mins ago

kevin clinekevin cline

32516

share|improve this question

edited 2 mins ago

kevin cline

asked 58 mins ago

kevin clinekevin cline

32516

asked 58 mins ago

kevin clinekevin cline

32516

asked 58 mins ago

kevin clinekevin cline

32516