Error handling function (Win32/C)Suggestions for improving error handlingError handling for function calls to parse a GIF fileWin32 GDI+ memory and styleHandling an invalid SQL query exceptionEasy error handlingErrno-like C global error handlingAutomated document downloading, with error handlingRead and write BMP file in CError-Handling Class and Logging for VBA#Error Handling- Propagating errors to calling function.

Typing CO_2 easily

How to test the sharpness of a knife?

Is there anyway, I can have two passwords for my wi-fi

Can I cause damage to electrical appliances by unplugging them when they are turned on?

Pre-Employment Background Check With Consent For Future Checks

Why does a 97 / 92 key piano exist by Bösendorfer?

Isometric embedding of a genus g surface

How to get directions in deep space?

Unable to disable Microsoft Store in domain environment

Why didn’t Eve recognize the little cockroach as a living organism?

How to preserve electronics (computers, iPads and phones) for hundreds of years

Determining multivariate least squares with constraint

Would this string work as string?

What's the name of the logical fallacy where a debater extends a statement far beyond the original statement to make it true?

Air travel with refrigerated insulin

Do I have to take mana from my deck or hand when tapping a dual land?

Cumulative Sum using Java 8 stream API

Consistent Linux device enumeration

How much do grades matter for a future academia position?

PTIJ: does fasting on Ta'anis Esther give us reward as if we celebrated 2 Purims? (similar to Yom Kippur)

Proving a complicated language is not a CFL

Has the laser at Magurele, Romania reached a tenth of the Sun's power?

Why would five hundred and five be same as one?

Do I have to know the General Relativity theory to understand the concept of inertial frame?



Error handling function (Win32/C)


Suggestions for improving error handlingError handling for function calls to parse a GIF fileWin32 GDI+ memory and styleHandling an invalid SQL query exceptionEasy error handlingErrno-like C global error handlingAutomated document downloading, with error handlingRead and write BMP file in CError-Handling Class and Logging for VBA#Error Handling- Propagating errors to calling function.













0












$begingroup$


I have written the following function to be a general "error logging" solution for my Windows API projects. Basically, given a Windows system error code (a la GetLastError()), it will log the error message into a file:



#include <Windows.h>
#include <strsafe.h>

// MAX_PATH for file name, 12 for max signed int in base 10 (-2147483648), 20 for datetime string, 5 for brackets/colon/spaces
#define MAX_DFL_LENGTH (MAX_PATH + 37)

// So that it can be used as a callback if desired
typedef VOID(CALLBACK *ERRORPROC)(DWORD, WCHAR *, INT, HANDLE, BOOL);

/**
* Logs an error message that occurred elsewhere in the program.
* PARAMETERS:
* dwError - The system error code to process.
* wszFileName - The name of the file in which the error occurred (pass __FILEW__)
* nLine - The line at which the error was detected (pass __LINE__)
* hOutFile - A handle to an already open file for writing the error message to.
* fRecoverable - If true, this error is recoverable; return to the calling code. If false, exit after logging the error.
*/
VOID CALLBACK ErrorProc(
DWORD dwError,
WCHAR *wszFileName,
INT nLine,
HANDLE hOutFile,
BOOL fRecoverable
)

LPWSTR lpMsgBuf;
DWORD dwWritten;
HRESULT hr;
UINT uLen;
SYSTEMTIME st;
WCHAR wszDateFileLine[MAX_DFL_LENGTH];
CONST WCHAR *wRecovMsg[2] = L" Not recoverable, exiting program.rn", L" Recoverable; continuing execution...rn" ;

(VOID)FormatMessageW(
FORMAT_MESSAGE_ALLOCATE_BUFFER


While this historically worked well enough for my personal projects, I am wondering if there are any modifications I should make to the presentation or operation of this function before suggesting its addition to a larger Windows project with an entire team of developers.









share









$endgroup$
















    0












    $begingroup$


    I have written the following function to be a general "error logging" solution for my Windows API projects. Basically, given a Windows system error code (a la GetLastError()), it will log the error message into a file:



    #include <Windows.h>
    #include <strsafe.h>

    // MAX_PATH for file name, 12 for max signed int in base 10 (-2147483648), 20 for datetime string, 5 for brackets/colon/spaces
    #define MAX_DFL_LENGTH (MAX_PATH + 37)

    // So that it can be used as a callback if desired
    typedef VOID(CALLBACK *ERRORPROC)(DWORD, WCHAR *, INT, HANDLE, BOOL);

    /**
    * Logs an error message that occurred elsewhere in the program.
    * PARAMETERS:
    * dwError - The system error code to process.
    * wszFileName - The name of the file in which the error occurred (pass __FILEW__)
    * nLine - The line at which the error was detected (pass __LINE__)
    * hOutFile - A handle to an already open file for writing the error message to.
    * fRecoverable - If true, this error is recoverable; return to the calling code. If false, exit after logging the error.
    */
    VOID CALLBACK ErrorProc(
    DWORD dwError,
    WCHAR *wszFileName,
    INT nLine,
    HANDLE hOutFile,
    BOOL fRecoverable
    )

    LPWSTR lpMsgBuf;
    DWORD dwWritten;
    HRESULT hr;
    UINT uLen;
    SYSTEMTIME st;
    WCHAR wszDateFileLine[MAX_DFL_LENGTH];
    CONST WCHAR *wRecovMsg[2] = L" Not recoverable, exiting program.rn", L" Recoverable; continuing execution...rn" ;

    (VOID)FormatMessageW(
    FORMAT_MESSAGE_ALLOCATE_BUFFER


    While this historically worked well enough for my personal projects, I am wondering if there are any modifications I should make to the presentation or operation of this function before suggesting its addition to a larger Windows project with an entire team of developers.









    share









    $endgroup$














      0












      0








      0





      $begingroup$


      I have written the following function to be a general "error logging" solution for my Windows API projects. Basically, given a Windows system error code (a la GetLastError()), it will log the error message into a file:



      #include <Windows.h>
      #include <strsafe.h>

      // MAX_PATH for file name, 12 for max signed int in base 10 (-2147483648), 20 for datetime string, 5 for brackets/colon/spaces
      #define MAX_DFL_LENGTH (MAX_PATH + 37)

      // So that it can be used as a callback if desired
      typedef VOID(CALLBACK *ERRORPROC)(DWORD, WCHAR *, INT, HANDLE, BOOL);

      /**
      * Logs an error message that occurred elsewhere in the program.
      * PARAMETERS:
      * dwError - The system error code to process.
      * wszFileName - The name of the file in which the error occurred (pass __FILEW__)
      * nLine - The line at which the error was detected (pass __LINE__)
      * hOutFile - A handle to an already open file for writing the error message to.
      * fRecoverable - If true, this error is recoverable; return to the calling code. If false, exit after logging the error.
      */
      VOID CALLBACK ErrorProc(
      DWORD dwError,
      WCHAR *wszFileName,
      INT nLine,
      HANDLE hOutFile,
      BOOL fRecoverable
      )

      LPWSTR lpMsgBuf;
      DWORD dwWritten;
      HRESULT hr;
      UINT uLen;
      SYSTEMTIME st;
      WCHAR wszDateFileLine[MAX_DFL_LENGTH];
      CONST WCHAR *wRecovMsg[2] = L" Not recoverable, exiting program.rn", L" Recoverable; continuing execution...rn" ;

      (VOID)FormatMessageW(
      FORMAT_MESSAGE_ALLOCATE_BUFFER


      While this historically worked well enough for my personal projects, I am wondering if there are any modifications I should make to the presentation or operation of this function before suggesting its addition to a larger Windows project with an entire team of developers.









      share









      $endgroup$




      I have written the following function to be a general "error logging" solution for my Windows API projects. Basically, given a Windows system error code (a la GetLastError()), it will log the error message into a file:



      #include <Windows.h>
      #include <strsafe.h>

      // MAX_PATH for file name, 12 for max signed int in base 10 (-2147483648), 20 for datetime string, 5 for brackets/colon/spaces
      #define MAX_DFL_LENGTH (MAX_PATH + 37)

      // So that it can be used as a callback if desired
      typedef VOID(CALLBACK *ERRORPROC)(DWORD, WCHAR *, INT, HANDLE, BOOL);

      /**
      * Logs an error message that occurred elsewhere in the program.
      * PARAMETERS:
      * dwError - The system error code to process.
      * wszFileName - The name of the file in which the error occurred (pass __FILEW__)
      * nLine - The line at which the error was detected (pass __LINE__)
      * hOutFile - A handle to an already open file for writing the error message to.
      * fRecoverable - If true, this error is recoverable; return to the calling code. If false, exit after logging the error.
      */
      VOID CALLBACK ErrorProc(
      DWORD dwError,
      WCHAR *wszFileName,
      INT nLine,
      HANDLE hOutFile,
      BOOL fRecoverable
      )

      LPWSTR lpMsgBuf;
      DWORD dwWritten;
      HRESULT hr;
      UINT uLen;
      SYSTEMTIME st;
      WCHAR wszDateFileLine[MAX_DFL_LENGTH];
      CONST WCHAR *wRecovMsg[2] = L" Not recoverable, exiting program.rn", L" Recoverable; continuing execution...rn" ;

      (VOID)FormatMessageW(
      FORMAT_MESSAGE_ALLOCATE_BUFFER


      While this historically worked well enough for my personal projects, I am wondering if there are any modifications I should make to the presentation or operation of this function before suggesting its addition to a larger Windows project with an entire team of developers.







      c error-handling winapi





      share












      share










      share



      share










      asked 2 mins ago









      Govind ParmarGovind Parmar

      25729




      25729




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215879%2ferror-handling-function-win32-c%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















          draft saved

          draft discarded
















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215879%2ferror-handling-function-win32-c%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          बाताम इन्हें भी देखें सन्दर्भ दिक्चालन सूची1°05′00″N 104°02′0″E / 1.08333°N 104.03333°E / 1.08333; 104.033331°05′00″N 104°02′0″E / 1.08333°N 104.03333°E / 1.08333; 104.03333

          Why is the 'in' operator throwing an error with a string literal instead of logging false?Why can't I use switch statement on a String?Python join: why is it string.join(list) instead of list.join(string)?Multiline String Literal in C#Why does comparing strings using either '==' or 'is' sometimes produce a different result?How to initialize an array's length in javascript?How can I print literal curly-brace characters in python string and also use .format on it?Why does ++[[]][+[]]+[+[]] return the string “10”?Why is char[] preferred over String for passwords?Why does this code using random strings print “hello world”?jQuery.inArray(), how to use it right?

          How can we generalize the fact of finite dimensional vector space to an infinte dimensional case?$k[x]$-module and cyclic module over a finite dimensional vector spaceSubspace of a finite dimensional space is finite dimensionalIf V is an infinite-dimensional vector space, and S is an infinite-dimensional subspace of V, must the dimension of V/S be finite? ExplainWhy is an infinite dimensional space so different than a finite dimensional one?base for finite dimensional vector space is not infinite dimensional vector space?Any finite-dimensional vector space is the dual space of anotherHaving Trouble Understanding Meaning Of A Finite-Dimensional Vector SpaceProve that “Every subspaces of a finite-dimensional vector space is finite-dimensional”Ring as a finite dimensional Vector space over a field KQuestion regarding basis and dimension