Go program - Looking for advicemultiple threaded program vb.netParsing a page's source code for URLsBouncing ball programLong running, frequent async advice?Multithreading pthread programIs this program susceptible to a buffer overflow exploit?cat program in GoGolang Tour Web Crawler ExerciseDiff for successive sorted sliceCLI Utility Go - First Go Program

Why is the sun approximated as a black body at ~ 5800 K?

Sigmoid with a slope but no asymptotes?

Origin of pigs as a species

PTIJ: does fasting on Ta'anis Esther give us reward as if we celebrated 2 Purims? (similar to Yom Kippur)

Storage of electrolytic capacitors - how long?

Deciphering cause of death?

Are Captain Marvel's powers affected by Thanos breaking the Tesseract and claiming the stone?

Showing mass murder in a kid's book

El Dorado Word Puzzle II: Videogame Edition

Proving an identity involving cross products and coplanar vectors

Limit max CPU usage SQL SERVER with WSRM

Did I make a mistake by ccing email to boss to others?

If the only attacker is removed from combat, is a creature still counted as having attacked this turn?

What's the name of the logical fallacy where a debater extends a statement far beyond the original statement to make it true?

SOQL query causes internal Salesforce error

Mimic lecturing on blackboard, facing audience

Why the "ls" command is showing the permissions of files in a FAT32 partition?

What happens if I try to grapple mirror image?

Do you waste sorcery points if you try to apply metamagic to a spell from a scroll but fail to cast it?

Can I say "fingers" when referring to toes?

Unable to disable Microsoft Store in domain environment

Overlapping circles covering polygon

Would this string work as string?

Review your own paper in Mathematics



Go program - Looking for advice


multiple threaded program vb.netParsing a page's source code for URLsBouncing ball programLong running, frequent async advice?Multithreading pthread programIs this program susceptible to a buffer overflow exploit?cat program in GoGolang Tour Web Crawler ExerciseDiff for successive sorted sliceCLI Utility Go - First Go Program













0












$begingroup$


Hello everyone ! :)



I'm beginning to learn about Golang and I would like to have some advice about the following program ^^



package main

import (
"fmt"
"net/http"
"time"
)

const BenchmarkTry = 1000

type PageBenchmark struct
url string
time int64 // microseconds


func execBenchmark(url string, channel chan PageBenchmark)
totalExecTimeChan := make(chan int64, BenchmarkTry) // set size to prevent blocked goroutine
totalExecTime := int64(0)

// start all the goroutines
for i := 0; i < BenchmarkTry; i++
go execHttpRequest(url, totalExecTimeChan)


// catch new values from totalExecTimeChan values come from execHttpRequest()) and add it to the total
for i := 0; i < BenchmarkTry; i++
totalExecTime += <-totalExecTimeChan // waiting to get a value from one of the goroutines started in the previous for loop


channel <- PageBenchmarkurl, totalExecTime / BenchmarkTry


// exec http request and attach exec time to channel
func execHttpRequest(url string, channel chan int64)
begin := time.Now()
_, _ = http.Get(url)
channel <- time.Since(begin).Nanoseconds() / 1000000 // convert to milliseconds


func main()
sites := [...]string



pages := [...]string



benchmarkChan := make(chan PageBenchmark, len(sites)*len(pages)) // set size to prevent blocked goroutine

begin := time.Now()
fmt.Println("Beginning !")

// start all the goroutines
for site := range sites
for page := range pages
go execBenchmark(sites[site]+pages[page], benchmarkChan)



// catch new values from benchmarkChan and "print" the PageBenchmark
for i := 0; i < len(sites)*len(pages); i++
benchmark := <-benchmarkChan
fmt.Printf("Url : %vnResponse Time : %d msnn", benchmark.url, benchmark.time)


// print execution time
fmt.Println("End.")
fmt.Println(fmt.Sprintf("%d ms", time.Since(begin).Nanoseconds()/1000000))




So basically here, I'm making HTTP requests (GET method) to multiple urls on multiple web sites. 1000 requests by url in this example.



For now, I just want to start some goroutines in this order :




  • (First goroutine) mainroutine : start a benchmark (goroutine) foreach web site pages, get the average execution time and print it




    • (Second goroutine) page routine : start 1000 goroutines (benchmark tries), get the execution times from a channel and store the average execution time in an other channel



      • (Third goroutine) Execute an HTTP request on the page and store the execution time in a channel



Actually, this piece of code "works" but I'm not sure that it "works" as intended.



  • Is that the case ?


  • Is the execution scheduling valid ?


  • Is it appropriate to use defined size channels here ?


  • Is there a better/more effective way to achieve this task ?


I would be very grateful if you would please take some time to read this topic :) Thank you and have a nice day ;)









share







New contributor




hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    Hello everyone ! :)



    I'm beginning to learn about Golang and I would like to have some advice about the following program ^^



    package main

    import (
    "fmt"
    "net/http"
    "time"
    )

    const BenchmarkTry = 1000

    type PageBenchmark struct
    url string
    time int64 // microseconds


    func execBenchmark(url string, channel chan PageBenchmark)
    totalExecTimeChan := make(chan int64, BenchmarkTry) // set size to prevent blocked goroutine
    totalExecTime := int64(0)

    // start all the goroutines
    for i := 0; i < BenchmarkTry; i++
    go execHttpRequest(url, totalExecTimeChan)


    // catch new values from totalExecTimeChan values come from execHttpRequest()) and add it to the total
    for i := 0; i < BenchmarkTry; i++
    totalExecTime += <-totalExecTimeChan // waiting to get a value from one of the goroutines started in the previous for loop


    channel <- PageBenchmarkurl, totalExecTime / BenchmarkTry


    // exec http request and attach exec time to channel
    func execHttpRequest(url string, channel chan int64)
    begin := time.Now()
    _, _ = http.Get(url)
    channel <- time.Since(begin).Nanoseconds() / 1000000 // convert to milliseconds


    func main()
    sites := [...]string



    pages := [...]string



    benchmarkChan := make(chan PageBenchmark, len(sites)*len(pages)) // set size to prevent blocked goroutine

    begin := time.Now()
    fmt.Println("Beginning !")

    // start all the goroutines
    for site := range sites
    for page := range pages
    go execBenchmark(sites[site]+pages[page], benchmarkChan)



    // catch new values from benchmarkChan and "print" the PageBenchmark
    for i := 0; i < len(sites)*len(pages); i++
    benchmark := <-benchmarkChan
    fmt.Printf("Url : %vnResponse Time : %d msnn", benchmark.url, benchmark.time)


    // print execution time
    fmt.Println("End.")
    fmt.Println(fmt.Sprintf("%d ms", time.Since(begin).Nanoseconds()/1000000))




    So basically here, I'm making HTTP requests (GET method) to multiple urls on multiple web sites. 1000 requests by url in this example.



    For now, I just want to start some goroutines in this order :




    • (First goroutine) mainroutine : start a benchmark (goroutine) foreach web site pages, get the average execution time and print it




      • (Second goroutine) page routine : start 1000 goroutines (benchmark tries), get the execution times from a channel and store the average execution time in an other channel



        • (Third goroutine) Execute an HTTP request on the page and store the execution time in a channel



    Actually, this piece of code "works" but I'm not sure that it "works" as intended.



    • Is that the case ?


    • Is the execution scheduling valid ?


    • Is it appropriate to use defined size channels here ?


    • Is there a better/more effective way to achieve this task ?


    I would be very grateful if you would please take some time to read this topic :) Thank you and have a nice day ;)









    share







    New contributor




    hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      Hello everyone ! :)



      I'm beginning to learn about Golang and I would like to have some advice about the following program ^^



      package main

      import (
      "fmt"
      "net/http"
      "time"
      )

      const BenchmarkTry = 1000

      type PageBenchmark struct
      url string
      time int64 // microseconds


      func execBenchmark(url string, channel chan PageBenchmark)
      totalExecTimeChan := make(chan int64, BenchmarkTry) // set size to prevent blocked goroutine
      totalExecTime := int64(0)

      // start all the goroutines
      for i := 0; i < BenchmarkTry; i++
      go execHttpRequest(url, totalExecTimeChan)


      // catch new values from totalExecTimeChan values come from execHttpRequest()) and add it to the total
      for i := 0; i < BenchmarkTry; i++
      totalExecTime += <-totalExecTimeChan // waiting to get a value from one of the goroutines started in the previous for loop


      channel <- PageBenchmarkurl, totalExecTime / BenchmarkTry


      // exec http request and attach exec time to channel
      func execHttpRequest(url string, channel chan int64)
      begin := time.Now()
      _, _ = http.Get(url)
      channel <- time.Since(begin).Nanoseconds() / 1000000 // convert to milliseconds


      func main()
      sites := [...]string



      pages := [...]string



      benchmarkChan := make(chan PageBenchmark, len(sites)*len(pages)) // set size to prevent blocked goroutine

      begin := time.Now()
      fmt.Println("Beginning !")

      // start all the goroutines
      for site := range sites
      for page := range pages
      go execBenchmark(sites[site]+pages[page], benchmarkChan)



      // catch new values from benchmarkChan and "print" the PageBenchmark
      for i := 0; i < len(sites)*len(pages); i++
      benchmark := <-benchmarkChan
      fmt.Printf("Url : %vnResponse Time : %d msnn", benchmark.url, benchmark.time)


      // print execution time
      fmt.Println("End.")
      fmt.Println(fmt.Sprintf("%d ms", time.Since(begin).Nanoseconds()/1000000))




      So basically here, I'm making HTTP requests (GET method) to multiple urls on multiple web sites. 1000 requests by url in this example.



      For now, I just want to start some goroutines in this order :




      • (First goroutine) mainroutine : start a benchmark (goroutine) foreach web site pages, get the average execution time and print it




        • (Second goroutine) page routine : start 1000 goroutines (benchmark tries), get the execution times from a channel and store the average execution time in an other channel



          • (Third goroutine) Execute an HTTP request on the page and store the execution time in a channel



      Actually, this piece of code "works" but I'm not sure that it "works" as intended.



      • Is that the case ?


      • Is the execution scheduling valid ?


      • Is it appropriate to use defined size channels here ?


      • Is there a better/more effective way to achieve this task ?


      I would be very grateful if you would please take some time to read this topic :) Thank you and have a nice day ;)









      share







      New contributor




      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Hello everyone ! :)



      I'm beginning to learn about Golang and I would like to have some advice about the following program ^^



      package main

      import (
      "fmt"
      "net/http"
      "time"
      )

      const BenchmarkTry = 1000

      type PageBenchmark struct
      url string
      time int64 // microseconds


      func execBenchmark(url string, channel chan PageBenchmark)
      totalExecTimeChan := make(chan int64, BenchmarkTry) // set size to prevent blocked goroutine
      totalExecTime := int64(0)

      // start all the goroutines
      for i := 0; i < BenchmarkTry; i++
      go execHttpRequest(url, totalExecTimeChan)


      // catch new values from totalExecTimeChan values come from execHttpRequest()) and add it to the total
      for i := 0; i < BenchmarkTry; i++
      totalExecTime += <-totalExecTimeChan // waiting to get a value from one of the goroutines started in the previous for loop


      channel <- PageBenchmarkurl, totalExecTime / BenchmarkTry


      // exec http request and attach exec time to channel
      func execHttpRequest(url string, channel chan int64)
      begin := time.Now()
      _, _ = http.Get(url)
      channel <- time.Since(begin).Nanoseconds() / 1000000 // convert to milliseconds


      func main()
      sites := [...]string



      pages := [...]string



      benchmarkChan := make(chan PageBenchmark, len(sites)*len(pages)) // set size to prevent blocked goroutine

      begin := time.Now()
      fmt.Println("Beginning !")

      // start all the goroutines
      for site := range sites
      for page := range pages
      go execBenchmark(sites[site]+pages[page], benchmarkChan)



      // catch new values from benchmarkChan and "print" the PageBenchmark
      for i := 0; i < len(sites)*len(pages); i++
      benchmark := <-benchmarkChan
      fmt.Printf("Url : %vnResponse Time : %d msnn", benchmark.url, benchmark.time)


      // print execution time
      fmt.Println("End.")
      fmt.Println(fmt.Sprintf("%d ms", time.Since(begin).Nanoseconds()/1000000))




      So basically here, I'm making HTTP requests (GET method) to multiple urls on multiple web sites. 1000 requests by url in this example.



      For now, I just want to start some goroutines in this order :




      • (First goroutine) mainroutine : start a benchmark (goroutine) foreach web site pages, get the average execution time and print it




        • (Second goroutine) page routine : start 1000 goroutines (benchmark tries), get the execution times from a channel and store the average execution time in an other channel



          • (Third goroutine) Execute an HTTP request on the page and store the execution time in a channel



      Actually, this piece of code "works" but I'm not sure that it "works" as intended.



      • Is that the case ?


      • Is the execution scheduling valid ?


      • Is it appropriate to use defined size channels here ?


      • Is there a better/more effective way to achieve this task ?


      I would be very grateful if you would please take some time to read this topic :) Thank you and have a nice day ;)







      multithreading go http benchmarking





      share







      New contributor




      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 6 mins ago









      hunominahunomina

      1




      1




      New contributor




      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      hunomina is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          hunomina is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215883%2fgo-program-looking-for-advice%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          hunomina is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          hunomina is a new contributor. Be nice, and check out our Code of Conduct.












          hunomina is a new contributor. Be nice, and check out our Code of Conduct.











          hunomina is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215883%2fgo-program-looking-for-advice%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          बाताम इन्हें भी देखें सन्दर्भ दिक्चालन सूची1°05′00″N 104°02′0″E / 1.08333°N 104.03333°E / 1.08333; 104.033331°05′00″N 104°02′0″E / 1.08333°N 104.03333°E / 1.08333; 104.03333

          Why is the 'in' operator throwing an error with a string literal instead of logging false?Why can't I use switch statement on a String?Python join: why is it string.join(list) instead of list.join(string)?Multiline String Literal in C#Why does comparing strings using either '==' or 'is' sometimes produce a different result?How to initialize an array's length in javascript?How can I print literal curly-brace characters in python string and also use .format on it?Why does ++[[]][+[]]+[+[]] return the string “10”?Why is char[] preferred over String for passwords?Why does this code using random strings print “hello world”?jQuery.inArray(), how to use it right?

          How can we generalize the fact of finite dimensional vector space to an infinte dimensional case?$k[x]$-module and cyclic module over a finite dimensional vector spaceSubspace of a finite dimensional space is finite dimensionalIf V is an infinite-dimensional vector space, and S is an infinite-dimensional subspace of V, must the dimension of V/S be finite? ExplainWhy is an infinite dimensional space so different than a finite dimensional one?base for finite dimensional vector space is not infinite dimensional vector space?Any finite-dimensional vector space is the dual space of anotherHaving Trouble Understanding Meaning Of A Finite-Dimensional Vector SpaceProve that “Every subspaces of a finite-dimensional vector space is finite-dimensional”Ring as a finite dimensional Vector space over a field KQuestion regarding basis and dimension