Redux property modificationCRUD application using React-ReduxImplementing redirect in Redux middlewareBind component state to redux store stateReact/Redux 401 MiddlewareReact Redux quiz appGeneric dataloader for redux-thunk using axiosRewriting Crime Map - React Component with ReduxReact Redux default playgroundAngular + Redux app organization and initialization: transfer from a PHP-driven websiteRedux Recipe List

At what level can a dragon innately cast its spells?

What does it mean to make a bootable LiveUSB?

Can elves maintain concentration in a trance?

Why are the outputs of printf and std::cout different

Why must traveling waves have the same amplitude to form a standing wave?

PlotLabels with equations not expressions

Is it possible to upcast ritual spells?

Employee lack of ownership

Know when to turn notes upside-down(eighth notes, sixteen notes, etc.)

Why does Deadpool say "You're welcome, Canada," after shooting Ryan Reynolds in the end credits?

2D counterpart of std::array in C++17

Force user to remove USB token

Could the Saturn V actually have launched astronauts around Venus?

Converting Functions to Arrow functions

What are the possible solutions of the given equation?

How could a female member of a species produce eggs unto death?

Rejected in 4th interview round citing insufficient years of experience

Is it true that real estate prices mainly go up?

Official degrees of earth’s rotation per day

Why would a flight no longer considered airworthy be redirected like this?

Meaning of "SEVERA INDEOVI VAS" from 3rd Century slab

Have researchers managed to "reverse time"? If so, what does that mean for physics?

What is this large pipe coming out of my roof?

How do anti-virus programs start at Windows boot?



Redux property modification


CRUD application using React-ReduxImplementing redirect in Redux middlewareBind component state to redux store stateReact/Redux 401 MiddlewareReact Redux quiz appGeneric dataloader for redux-thunk using axiosRewriting Crime Map - React Component with ReduxReact Redux default playgroundAngular + Redux app organization and initialization: transfer from a PHP-driven websiteRedux Recipe List













0












$begingroup$


I have Redux store with data of IProperty[] type (defined as below).

Using ADD_PROPERTY, CHANGE_PROPERTY, CHANGE_PROP_TYPE, CHANGE_PROP_PARENT, UPDATE_PROP_PARENTS actions.



interface IProperty 
name: string;
type: string;
fullName: string;
parentRef: string;
errors:
name:
required: boolean;
duplicate: boolean;





It is working fine. Just would like to know if I am doing according to Redux patterns only.



Is it correct to update errors field on CHANGE_PROP_NAME action and fullName field for all actions?



Is it correct to



/**
* reducers.ts
*/
const getFullName = (property: IProperty): string => `$property.parentRef ? `$property.parentRef.` : ''$property.name`;
// Reducer for properties
export const properties = (previousState: any[] = [], action) =>
const payload = action;

switch (action.type)
case ADD_PROPERTY:

return previousState.concat(
...payload,
fullName: getFullName(payload)
);
case CHANGE_PROP_NAME:
return previousState.map((property: IProperty) =>
if (property.I__D === payload.I__D)
property.name = payload.name;
property.fullName = getFullName(payload);
property.errors.name =
required: !payload.name,
duplicate: previousState.some(prop => prop.I__D !== payload.I__D && prop.fullName === property.fullName)


return property;
);
case CHANGE_PROP_TYPE:
case CHANGE_PROP_PARENT:
return previousState.map((property: IProperty) =>
if (property.I__D === payload.I__D)
return
...payload,
fullName: getFullName(payload)
;

return property;
);
default:
return previousState;

;

// Reducer for parent properties
export const parentProperties = (previousState: any[] = [], action) =>
switch (action.type)
case UPDATE_PROP_PARENTS:
return action.payload.filter(prop => ['array', 'jsonObject'].indexOf(prop.type) !== -1);
default:
return previousState;

;


Is is correct to call UPDATE_PROP_PARENTS action along with other actions from React component?



/**
* Code utilizing `Redux Action creators` in React component
*/

private onNameChange(evt: FormEvent)
this.props.changePropName(MProperty.extract(
...this.props,
name: this.elName.value
));
this.props.updatePropParents();


private onTypeChange(evt: FormEvent)
this.props.changePropType(MProperty.extract(
...this.props,
type: this.elDataType.value,
options: undefined
));
this.props.updatePropParents();


private onParentChange(evt: FormEvent)
this.props.changePropParent(MProperty.extract(
...this.props,
parentRef: this.elParent.value
));
this.props.updatePropParents();










share|improve this question









New contributor




Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I have Redux store with data of IProperty[] type (defined as below).

    Using ADD_PROPERTY, CHANGE_PROPERTY, CHANGE_PROP_TYPE, CHANGE_PROP_PARENT, UPDATE_PROP_PARENTS actions.



    interface IProperty 
    name: string;
    type: string;
    fullName: string;
    parentRef: string;
    errors:
    name:
    required: boolean;
    duplicate: boolean;





    It is working fine. Just would like to know if I am doing according to Redux patterns only.



    Is it correct to update errors field on CHANGE_PROP_NAME action and fullName field for all actions?



    Is it correct to



    /**
    * reducers.ts
    */
    const getFullName = (property: IProperty): string => `$property.parentRef ? `$property.parentRef.` : ''$property.name`;
    // Reducer for properties
    export const properties = (previousState: any[] = [], action) =>
    const payload = action;

    switch (action.type)
    case ADD_PROPERTY:

    return previousState.concat(
    ...payload,
    fullName: getFullName(payload)
    );
    case CHANGE_PROP_NAME:
    return previousState.map((property: IProperty) =>
    if (property.I__D === payload.I__D)
    property.name = payload.name;
    property.fullName = getFullName(payload);
    property.errors.name =
    required: !payload.name,
    duplicate: previousState.some(prop => prop.I__D !== payload.I__D && prop.fullName === property.fullName)


    return property;
    );
    case CHANGE_PROP_TYPE:
    case CHANGE_PROP_PARENT:
    return previousState.map((property: IProperty) =>
    if (property.I__D === payload.I__D)
    return
    ...payload,
    fullName: getFullName(payload)
    ;

    return property;
    );
    default:
    return previousState;

    ;

    // Reducer for parent properties
    export const parentProperties = (previousState: any[] = [], action) =>
    switch (action.type)
    case UPDATE_PROP_PARENTS:
    return action.payload.filter(prop => ['array', 'jsonObject'].indexOf(prop.type) !== -1);
    default:
    return previousState;

    ;


    Is is correct to call UPDATE_PROP_PARENTS action along with other actions from React component?



    /**
    * Code utilizing `Redux Action creators` in React component
    */

    private onNameChange(evt: FormEvent)
    this.props.changePropName(MProperty.extract(
    ...this.props,
    name: this.elName.value
    ));
    this.props.updatePropParents();


    private onTypeChange(evt: FormEvent)
    this.props.changePropType(MProperty.extract(
    ...this.props,
    type: this.elDataType.value,
    options: undefined
    ));
    this.props.updatePropParents();


    private onParentChange(evt: FormEvent)
    this.props.changePropParent(MProperty.extract(
    ...this.props,
    parentRef: this.elParent.value
    ));
    this.props.updatePropParents();










    share|improve this question









    New contributor




    Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I have Redux store with data of IProperty[] type (defined as below).

      Using ADD_PROPERTY, CHANGE_PROPERTY, CHANGE_PROP_TYPE, CHANGE_PROP_PARENT, UPDATE_PROP_PARENTS actions.



      interface IProperty 
      name: string;
      type: string;
      fullName: string;
      parentRef: string;
      errors:
      name:
      required: boolean;
      duplicate: boolean;





      It is working fine. Just would like to know if I am doing according to Redux patterns only.



      Is it correct to update errors field on CHANGE_PROP_NAME action and fullName field for all actions?



      Is it correct to



      /**
      * reducers.ts
      */
      const getFullName = (property: IProperty): string => `$property.parentRef ? `$property.parentRef.` : ''$property.name`;
      // Reducer for properties
      export const properties = (previousState: any[] = [], action) =>
      const payload = action;

      switch (action.type)
      case ADD_PROPERTY:

      return previousState.concat(
      ...payload,
      fullName: getFullName(payload)
      );
      case CHANGE_PROP_NAME:
      return previousState.map((property: IProperty) =>
      if (property.I__D === payload.I__D)
      property.name = payload.name;
      property.fullName = getFullName(payload);
      property.errors.name =
      required: !payload.name,
      duplicate: previousState.some(prop => prop.I__D !== payload.I__D && prop.fullName === property.fullName)


      return property;
      );
      case CHANGE_PROP_TYPE:
      case CHANGE_PROP_PARENT:
      return previousState.map((property: IProperty) =>
      if (property.I__D === payload.I__D)
      return
      ...payload,
      fullName: getFullName(payload)
      ;

      return property;
      );
      default:
      return previousState;

      ;

      // Reducer for parent properties
      export const parentProperties = (previousState: any[] = [], action) =>
      switch (action.type)
      case UPDATE_PROP_PARENTS:
      return action.payload.filter(prop => ['array', 'jsonObject'].indexOf(prop.type) !== -1);
      default:
      return previousState;

      ;


      Is is correct to call UPDATE_PROP_PARENTS action along with other actions from React component?



      /**
      * Code utilizing `Redux Action creators` in React component
      */

      private onNameChange(evt: FormEvent)
      this.props.changePropName(MProperty.extract(
      ...this.props,
      name: this.elName.value
      ));
      this.props.updatePropParents();


      private onTypeChange(evt: FormEvent)
      this.props.changePropType(MProperty.extract(
      ...this.props,
      type: this.elDataType.value,
      options: undefined
      ));
      this.props.updatePropParents();


      private onParentChange(evt: FormEvent)
      this.props.changePropParent(MProperty.extract(
      ...this.props,
      parentRef: this.elParent.value
      ));
      this.props.updatePropParents();










      share|improve this question









      New contributor




      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have Redux store with data of IProperty[] type (defined as below).

      Using ADD_PROPERTY, CHANGE_PROPERTY, CHANGE_PROP_TYPE, CHANGE_PROP_PARENT, UPDATE_PROP_PARENTS actions.



      interface IProperty 
      name: string;
      type: string;
      fullName: string;
      parentRef: string;
      errors:
      name:
      required: boolean;
      duplicate: boolean;





      It is working fine. Just would like to know if I am doing according to Redux patterns only.



      Is it correct to update errors field on CHANGE_PROP_NAME action and fullName field for all actions?



      Is it correct to



      /**
      * reducers.ts
      */
      const getFullName = (property: IProperty): string => `$property.parentRef ? `$property.parentRef.` : ''$property.name`;
      // Reducer for properties
      export const properties = (previousState: any[] = [], action) =>
      const payload = action;

      switch (action.type)
      case ADD_PROPERTY:

      return previousState.concat(
      ...payload,
      fullName: getFullName(payload)
      );
      case CHANGE_PROP_NAME:
      return previousState.map((property: IProperty) =>
      if (property.I__D === payload.I__D)
      property.name = payload.name;
      property.fullName = getFullName(payload);
      property.errors.name =
      required: !payload.name,
      duplicate: previousState.some(prop => prop.I__D !== payload.I__D && prop.fullName === property.fullName)


      return property;
      );
      case CHANGE_PROP_TYPE:
      case CHANGE_PROP_PARENT:
      return previousState.map((property: IProperty) =>
      if (property.I__D === payload.I__D)
      return
      ...payload,
      fullName: getFullName(payload)
      ;

      return property;
      );
      default:
      return previousState;

      ;

      // Reducer for parent properties
      export const parentProperties = (previousState: any[] = [], action) =>
      switch (action.type)
      case UPDATE_PROP_PARENTS:
      return action.payload.filter(prop => ['array', 'jsonObject'].indexOf(prop.type) !== -1);
      default:
      return previousState;

      ;


      Is is correct to call UPDATE_PROP_PARENTS action along with other actions from React component?



      /**
      * Code utilizing `Redux Action creators` in React component
      */

      private onNameChange(evt: FormEvent)
      this.props.changePropName(MProperty.extract(
      ...this.props,
      name: this.elName.value
      ));
      this.props.updatePropParents();


      private onTypeChange(evt: FormEvent)
      this.props.changePropType(MProperty.extract(
      ...this.props,
      type: this.elDataType.value,
      options: undefined
      ));
      this.props.updatePropParents();


      private onParentChange(evt: FormEvent)
      this.props.changePropParent(MProperty.extract(
      ...this.props,
      parentRef: this.elParent.value
      ));
      this.props.updatePropParents();







      react.js typescript properties redux






      share|improve this question









      New contributor




      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.











      share|improve this question









      New contributor




      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      share|improve this question




      share|improve this question








      edited 3 mins ago









      200_success

      130k17153419




      130k17153419






      New contributor




      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 39 mins ago









      VikramVikram

      101




      101




      New contributor




      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Vikram is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Vikram is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215475%2fredux-property-modification%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Vikram is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Vikram is a new contributor. Be nice, and check out our Code of Conduct.












          Vikram is a new contributor. Be nice, and check out our Code of Conduct.











          Vikram is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215475%2fredux-property-modification%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि