Vwwxrf

I have redux store with data of IProperty[] type (defined as below).

Using ADD_PROPERTY, CHANGE_PROPERTY, CHANGE_PROP_TYPE, CHANGE_PROP_PARENT, UPDATE_PROP_PARENTS actions.

interface IProperty 
 name: string;
 type: string;
 fullName: string;
 parentRef: string;
 errors: 
 name: 
 required: boolean;
 duplicate: boolean;
 
 

It is working fine. Just would like to know if I am doing according to Redux patterns only.

Is it correct to update errors field on CHANGE_PROP_NAME action and fullName field for all actions?

Is it correct to

/**
 * reducers.ts
 */
const getFullName = (property: IProperty): string => `$property.parentRef ? `$property.parentRef.` : ''$property.name`;
// Reducer for properties
export const properties = (previousState: any[] = [], action) => 
 const payload = action;

 switch (action.type) 
 case ADD_PROPERTY:

 return previousState.concat(
 ...payload,
 fullName: getFullName(payload)
 );
 case CHANGE_PROP_NAME:
 return previousState.map((property: IProperty) => 
 if (property.I__D === payload.I__D) 
 property.name = payload.name;
 property.fullName = getFullName(payload);
 property.errors.name = 
 required: !payload.name,
 duplicate: previousState.some(prop => prop.I__D !== payload.I__D && prop.fullName === property.fullName)
 
 
 return property;
 );
 case CHANGE_PROP_TYPE:
 case CHANGE_PROP_PARENT:
 return previousState.map((property: IProperty) => 
 if (property.I__D === payload.I__D) 
 return 
 ...payload,
 fullName: getFullName(payload)
 ;
 
 return property;
 );
 default:
 return previousState;
 
;

// Reducer for parent properties
export const parentProperties = (previousState: any[] = [], action) => 
 switch (action.type) 
 case UPDATE_PROP_PARENTS:
 return action.payload.filter(prop => ['array', 'jsonObject'].indexOf(prop.type) !== -1);
 default:
 return previousState;
 
;

Is is correct to call UPDATE_PROP_PARENTS action along with other actions from React component?

/**
 * Code utilizing `Redux Action creators` in React component
 */

private onNameChange(evt: FormEvent) 
 this.props.changePropName(MProperty.extract(
 ...this.props,
 name: this.elName.value
 ));
 this.props.updatePropParents();


private onTypeChange(evt: FormEvent) 
 this.props.changePropType(MProperty.extract(
 ...this.props,
 type: this.elDataType.value,
 options: undefined
 ));
 this.props.updatePropParents();


private onParentChange(evt: FormEvent) 
 this.props.changePropParent(MProperty.extract(
 ...this.props,
 parentRef: this.elParent.value
 ));
 this.props.updatePropParents();