Whats wrong with these classes and bool variables?Is this the wrong way to handle AggregateException with TasksAdd getters and setters to a set of variablesLoading a combobox with an enum and binding to itAbstract classes with operator overloadingLogin functionality with enum or boolVariables, references and pointers - Write the function zero (…) so that the following code works correctlyVariables, references and pointers - Write the function set (…) so that the following code works correctlyCalculate subtotals and totals from a form with many decimal valuesUnquoting booleans, numbers, etc. in a JSON stringParse and TryParse methods for phone numbers

Taxes on Dividends in a Roth IRA

Does Doodling or Improvising on the Piano Have Any Benefits?

Why does Carol not get rid of the Kree symbol on her suit when she changes its colours?

A Trivial Diagnosis

How can I write humor as character trait?

What are some good ways to treat frozen vegetables such that they behave like fresh vegetables when stir frying them?

What to do when eye contact makes your coworker uncomfortable?

Why is the "ls" command showing permissions of files in a FAT32 partition?

How to get directions in deep space?

Delete multiple columns using awk or sed

Is this part of the description of the Archfey warlock's Misty Escape feature redundant?

Is my low blitz game drawing rate at www.chess.com an indicator that I am weak in chess?

Why do Radio Buttons not fill the entire outer circle?

Is there a nicer/politer/more positive alternative for "negates"?

How to preserve electronics (computers, iPads and phones) for hundreds of years

Which was the first story featuring espers?

Does the reader need to like the PoV character?

Biological Blimps: Propulsion

What (the heck) is a Super Worm Equinox Moon?

Does grappling negate Mirror Image?

Quoting Keynes in a lecture

The Digit Triangles

How much theory knowledge is actually used while playing?

Why Shazam when there is already Superman?



Whats wrong with these classes and bool variables?


Is this the wrong way to handle AggregateException with TasksAdd getters and setters to a set of variablesLoading a combobox with an enum and binding to itAbstract classes with operator overloadingLogin functionality with enum or boolVariables, references and pointers - Write the function zero (…) so that the following code works correctlyVariables, references and pointers - Write the function set (…) so that the following code works correctlyCalculate subtotals and totals from a form with many decimal valuesUnquoting booleans, numbers, etc. in a JSON stringParse and TryParse methods for phone numbers













0












$begingroup$


Im making a windows forms app to request contact information. I created a class to trim the input text and check if the textbox is empty. I also assigned patterns for the email and phonenumber. However the text isnt following the regex and isnt catching any exceptions either.



the form only has one button and it should compile and present the information inserted into the textbox.



I used the Get request method for the strings collected from the textbox. Here is the bool.



 bool GetPhone(ref string phonenumber)

bool success = true;
try

txtPhone.Text=Input.TrimText(txtPhone.Text);
if (Input.IsTextEmpty(txtPhone.Text))
throw new InputRequiredException();

phonenumber = txtPhone.Text;
Regex Regphone = new Regex(@"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$");
Match matchphone = Regphone.Match(phonenumber);
if (matchphone.Success)
success = true;
else throw new InputRequiredException();

catch(Exception error)

string remediation = "Enter a valid phone number.";
Input.ShowError(error, remediation);
Input.SelectText(txtPhone);

try

int Phone = Convert.ToInt32(txtPhone.Text);

success = true;

catch (Exception error)

string remediation = "Enter a valid phone number.";
Input.ShowError(error, remediation);
Input.SelectText(txtPhone);


return success;



Input class



 class Input


static public string TrimText(string A)

return A.Trim();


internal static bool IsTextEmpty(string A)

if (string.IsNullOrEmpty(A))

return true;


else

return false;



internal static void ShowError(object error, string remediation)




static public void SelectText(TextBox textBox1)

textBox1.SelectAll();




Exception class



 internal class InputRequiredException : Exception

public InputRequiredException()



public InputRequiredException(string message) : base(message)

message = "Invalid Input.";


public InputRequiredException(string message, Exception innerException) : base(message, innerException)



protected InputRequiredException(SerializationInfo info, StreamingContext context) : base(info, context)





The form contains one button and the code for clicking on it is:



 private void btnContact_Click(object sender, EventArgs e)

// Input variables
string quantity = string.Empty;
string name = string.Empty;
string emailpattern = @"^[A-Z0-9._%+-]+@[A-Z0-9.-]+.[A-Z]2,$";
string phonenumber = @"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$";

// Contact Date
DateTime contactDate = DateTime.MinValue;

// Contact Method
ContactMethod method = ContactMethod.Unassigned;

// Gather inputs
if
(
GetContactDate(ref contactDate) &&
GetContactMethod(ref method) &&
GetEmail(ref emailpattern) &&
GetName(ref name) &&
GetQuantity(ref quantity) &&
GetPhone(ref phonenumber)
)

// Submit contact request and close the form
string format =
"Your contact request has been entered.nn" +
"Quantity: 0n" +
"Name: 1n" +
"Email: 2n" +
"Phone: 3n" +
"Contact Date: 4:Dn" +
"Contact Method: 5n";
string msg = string.Format(format, quantity, name, emailpattern, phonenumber, contactDate, method);
MessageBox.Show(msg, Application.ProductName);

Close();




There are no errors showing in the code and the program runs smoothly but I am not getting the desired output. What I need from the code is to accept the inputs in the textbox, validate them according to the regex pattern and return the value inputted by the user. The code should throw an exception if the textbox is empty or the input is invalid. Currently, the textbox is accepting any and all values, without any exceptions. If I don't enter any value it simply returns the pattern. I am an utter noob when it comes to coding and I understand the code might have logical errors. Whether there is one mistake or multiple or if the code is simply unfinished please feel free to let me know.









share







New contributor




Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    Im making a windows forms app to request contact information. I created a class to trim the input text and check if the textbox is empty. I also assigned patterns for the email and phonenumber. However the text isnt following the regex and isnt catching any exceptions either.



    the form only has one button and it should compile and present the information inserted into the textbox.



    I used the Get request method for the strings collected from the textbox. Here is the bool.



     bool GetPhone(ref string phonenumber)

    bool success = true;
    try

    txtPhone.Text=Input.TrimText(txtPhone.Text);
    if (Input.IsTextEmpty(txtPhone.Text))
    throw new InputRequiredException();

    phonenumber = txtPhone.Text;
    Regex Regphone = new Regex(@"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$");
    Match matchphone = Regphone.Match(phonenumber);
    if (matchphone.Success)
    success = true;
    else throw new InputRequiredException();

    catch(Exception error)

    string remediation = "Enter a valid phone number.";
    Input.ShowError(error, remediation);
    Input.SelectText(txtPhone);

    try

    int Phone = Convert.ToInt32(txtPhone.Text);

    success = true;

    catch (Exception error)

    string remediation = "Enter a valid phone number.";
    Input.ShowError(error, remediation);
    Input.SelectText(txtPhone);


    return success;



    Input class



     class Input


    static public string TrimText(string A)

    return A.Trim();


    internal static bool IsTextEmpty(string A)

    if (string.IsNullOrEmpty(A))

    return true;


    else

    return false;



    internal static void ShowError(object error, string remediation)




    static public void SelectText(TextBox textBox1)

    textBox1.SelectAll();




    Exception class



     internal class InputRequiredException : Exception

    public InputRequiredException()



    public InputRequiredException(string message) : base(message)

    message = "Invalid Input.";


    public InputRequiredException(string message, Exception innerException) : base(message, innerException)



    protected InputRequiredException(SerializationInfo info, StreamingContext context) : base(info, context)





    The form contains one button and the code for clicking on it is:



     private void btnContact_Click(object sender, EventArgs e)

    // Input variables
    string quantity = string.Empty;
    string name = string.Empty;
    string emailpattern = @"^[A-Z0-9._%+-]+@[A-Z0-9.-]+.[A-Z]2,$";
    string phonenumber = @"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$";

    // Contact Date
    DateTime contactDate = DateTime.MinValue;

    // Contact Method
    ContactMethod method = ContactMethod.Unassigned;

    // Gather inputs
    if
    (
    GetContactDate(ref contactDate) &&
    GetContactMethod(ref method) &&
    GetEmail(ref emailpattern) &&
    GetName(ref name) &&
    GetQuantity(ref quantity) &&
    GetPhone(ref phonenumber)
    )

    // Submit contact request and close the form
    string format =
    "Your contact request has been entered.nn" +
    "Quantity: 0n" +
    "Name: 1n" +
    "Email: 2n" +
    "Phone: 3n" +
    "Contact Date: 4:Dn" +
    "Contact Method: 5n";
    string msg = string.Format(format, quantity, name, emailpattern, phonenumber, contactDate, method);
    MessageBox.Show(msg, Application.ProductName);

    Close();




    There are no errors showing in the code and the program runs smoothly but I am not getting the desired output. What I need from the code is to accept the inputs in the textbox, validate them according to the regex pattern and return the value inputted by the user. The code should throw an exception if the textbox is empty or the input is invalid. Currently, the textbox is accepting any and all values, without any exceptions. If I don't enter any value it simply returns the pattern. I am an utter noob when it comes to coding and I understand the code might have logical errors. Whether there is one mistake or multiple or if the code is simply unfinished please feel free to let me know.









    share







    New contributor




    Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      Im making a windows forms app to request contact information. I created a class to trim the input text and check if the textbox is empty. I also assigned patterns for the email and phonenumber. However the text isnt following the regex and isnt catching any exceptions either.



      the form only has one button and it should compile and present the information inserted into the textbox.



      I used the Get request method for the strings collected from the textbox. Here is the bool.



       bool GetPhone(ref string phonenumber)

      bool success = true;
      try

      txtPhone.Text=Input.TrimText(txtPhone.Text);
      if (Input.IsTextEmpty(txtPhone.Text))
      throw new InputRequiredException();

      phonenumber = txtPhone.Text;
      Regex Regphone = new Regex(@"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$");
      Match matchphone = Regphone.Match(phonenumber);
      if (matchphone.Success)
      success = true;
      else throw new InputRequiredException();

      catch(Exception error)

      string remediation = "Enter a valid phone number.";
      Input.ShowError(error, remediation);
      Input.SelectText(txtPhone);

      try

      int Phone = Convert.ToInt32(txtPhone.Text);

      success = true;

      catch (Exception error)

      string remediation = "Enter a valid phone number.";
      Input.ShowError(error, remediation);
      Input.SelectText(txtPhone);


      return success;



      Input class



       class Input


      static public string TrimText(string A)

      return A.Trim();


      internal static bool IsTextEmpty(string A)

      if (string.IsNullOrEmpty(A))

      return true;


      else

      return false;



      internal static void ShowError(object error, string remediation)




      static public void SelectText(TextBox textBox1)

      textBox1.SelectAll();




      Exception class



       internal class InputRequiredException : Exception

      public InputRequiredException()



      public InputRequiredException(string message) : base(message)

      message = "Invalid Input.";


      public InputRequiredException(string message, Exception innerException) : base(message, innerException)



      protected InputRequiredException(SerializationInfo info, StreamingContext context) : base(info, context)





      The form contains one button and the code for clicking on it is:



       private void btnContact_Click(object sender, EventArgs e)

      // Input variables
      string quantity = string.Empty;
      string name = string.Empty;
      string emailpattern = @"^[A-Z0-9._%+-]+@[A-Z0-9.-]+.[A-Z]2,$";
      string phonenumber = @"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$";

      // Contact Date
      DateTime contactDate = DateTime.MinValue;

      // Contact Method
      ContactMethod method = ContactMethod.Unassigned;

      // Gather inputs
      if
      (
      GetContactDate(ref contactDate) &&
      GetContactMethod(ref method) &&
      GetEmail(ref emailpattern) &&
      GetName(ref name) &&
      GetQuantity(ref quantity) &&
      GetPhone(ref phonenumber)
      )

      // Submit contact request and close the form
      string format =
      "Your contact request has been entered.nn" +
      "Quantity: 0n" +
      "Name: 1n" +
      "Email: 2n" +
      "Phone: 3n" +
      "Contact Date: 4:Dn" +
      "Contact Method: 5n";
      string msg = string.Format(format, quantity, name, emailpattern, phonenumber, contactDate, method);
      MessageBox.Show(msg, Application.ProductName);

      Close();




      There are no errors showing in the code and the program runs smoothly but I am not getting the desired output. What I need from the code is to accept the inputs in the textbox, validate them according to the regex pattern and return the value inputted by the user. The code should throw an exception if the textbox is empty or the input is invalid. Currently, the textbox is accepting any and all values, without any exceptions. If I don't enter any value it simply returns the pattern. I am an utter noob when it comes to coding and I understand the code might have logical errors. Whether there is one mistake or multiple or if the code is simply unfinished please feel free to let me know.









      share







      New contributor




      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Im making a windows forms app to request contact information. I created a class to trim the input text and check if the textbox is empty. I also assigned patterns for the email and phonenumber. However the text isnt following the regex and isnt catching any exceptions either.



      the form only has one button and it should compile and present the information inserted into the textbox.



      I used the Get request method for the strings collected from the textbox. Here is the bool.



       bool GetPhone(ref string phonenumber)

      bool success = true;
      try

      txtPhone.Text=Input.TrimText(txtPhone.Text);
      if (Input.IsTextEmpty(txtPhone.Text))
      throw new InputRequiredException();

      phonenumber = txtPhone.Text;
      Regex Regphone = new Regex(@"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$");
      Match matchphone = Regphone.Match(phonenumber);
      if (matchphone.Success)
      success = true;
      else throw new InputRequiredException();

      catch(Exception error)

      string remediation = "Enter a valid phone number.";
      Input.ShowError(error, remediation);
      Input.SelectText(txtPhone);

      try

      int Phone = Convert.ToInt32(txtPhone.Text);

      success = true;

      catch (Exception error)

      string remediation = "Enter a valid phone number.";
      Input.ShowError(error, remediation);
      Input.SelectText(txtPhone);


      return success;



      Input class



       class Input


      static public string TrimText(string A)

      return A.Trim();


      internal static bool IsTextEmpty(string A)

      if (string.IsNullOrEmpty(A))

      return true;


      else

      return false;



      internal static void ShowError(object error, string remediation)




      static public void SelectText(TextBox textBox1)

      textBox1.SelectAll();




      Exception class



       internal class InputRequiredException : Exception

      public InputRequiredException()



      public InputRequiredException(string message) : base(message)

      message = "Invalid Input.";


      public InputRequiredException(string message, Exception innerException) : base(message, innerException)



      protected InputRequiredException(SerializationInfo info, StreamingContext context) : base(info, context)





      The form contains one button and the code for clicking on it is:



       private void btnContact_Click(object sender, EventArgs e)

      // Input variables
      string quantity = string.Empty;
      string name = string.Empty;
      string emailpattern = @"^[A-Z0-9._%+-]+@[A-Z0-9.-]+.[A-Z]2,$";
      string phonenumber = @"^(+d1,2s)?(?d3)?[s.-]d3[s.-]d4$";

      // Contact Date
      DateTime contactDate = DateTime.MinValue;

      // Contact Method
      ContactMethod method = ContactMethod.Unassigned;

      // Gather inputs
      if
      (
      GetContactDate(ref contactDate) &&
      GetContactMethod(ref method) &&
      GetEmail(ref emailpattern) &&
      GetName(ref name) &&
      GetQuantity(ref quantity) &&
      GetPhone(ref phonenumber)
      )

      // Submit contact request and close the form
      string format =
      "Your contact request has been entered.nn" +
      "Quantity: 0n" +
      "Name: 1n" +
      "Email: 2n" +
      "Phone: 3n" +
      "Contact Date: 4:Dn" +
      "Contact Method: 5n";
      string msg = string.Format(format, quantity, name, emailpattern, phonenumber, contactDate, method);
      MessageBox.Show(msg, Application.ProductName);

      Close();




      There are no errors showing in the code and the program runs smoothly but I am not getting the desired output. What I need from the code is to accept the inputs in the textbox, validate them according to the regex pattern and return the value inputted by the user. The code should throw an exception if the textbox is empty or the input is invalid. Currently, the textbox is accepting any and all values, without any exceptions. If I don't enter any value it simply returns the pattern. I am an utter noob when it comes to coding and I understand the code might have logical errors. Whether there is one mistake or multiple or if the code is simply unfinished please feel free to let me know.







      c# regex winforms exception reference





      share







      New contributor




      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 9 mins ago









      Xavior HansaXavior Hansa

      1




      1




      New contributor




      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Xavior Hansa is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Xavior Hansa is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215965%2fwhats-wrong-with-these-classes-and-bool-variables%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Xavior Hansa is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Xavior Hansa is a new contributor. Be nice, and check out our Code of Conduct.












          Xavior Hansa is a new contributor. Be nice, and check out our Code of Conduct.











          Xavior Hansa is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215965%2fwhats-wrong-with-these-classes-and-bool-variables%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि