How to write an efficient code for the following tic-tac-toe game?Tic-Tac-Toe solverMinimax for Tic-Tac-ToeSimple class-oriented Tic Tac Toe game in C++Recursive Tic-Tac-Toe Solver in PythonUltimate Tic Tac Toe A.K.A. Tic TacticsTic Tac Toe game tree generator minimaxDesign Tic tac toe gameModularized Tic Tac Toe in CReproducing the known results for random tic tac toe play using PythonTic-Tac-Toe with React hooks

Paid for article while in US on F-1 visa?

What is a clear way to write a bar that has an extra beat?

How can bays and straits be determined in a procedurally generated map?

Add text to same line using sed

Arrow those variables!

Can you really stack all of this on an Opportunity Attack?

How is it possible to have an ability score that is less than 3?

Is there a name for fork-protected pieces?

How old can references or sources in a thesis be?

What would happen to a modern skyscraper if it rains micro blackholes?

How can I make my BBEG immortal short of making them a Lich or Vampire?

Why do I get two different answers for this counting problem?

dbcc cleantable batch size explanation

How much RAM could one put in a typical 80386 setup?

What's the point of deactivating Num Lock on login screens?

How do I draw and define two right triangles next to each other?

How to draw a waving flag in TikZ

What does it mean to describe someone as a butt steak?

Client team has low performances and low technical skills: we always fix their work and now they stop collaborate with us. How to solve?

What typically incentivizes a professor to change jobs to a lower ranking university?

Why "Having chlorophyll without photosynthesis is actually very dangerous" and "like living with a bomb"?

Is it tax fraud for an individual to declare non-taxable revenue as taxable income? (US tax laws)

Do I have a twin with permutated remainders?

Modeling an IP Address



How to write an efficient code for the following tic-tac-toe game?


Tic-Tac-Toe solverMinimax for Tic-Tac-ToeSimple class-oriented Tic Tac Toe game in C++Recursive Tic-Tac-Toe Solver in PythonUltimate Tic Tac Toe A.K.A. Tic TacticsTic Tac Toe game tree generator minimaxDesign Tic tac toe gameModularized Tic Tac Toe in CReproducing the known results for random tic tac toe play using PythonTic-Tac-Toe with React hooks






.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








0












$begingroup$


I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



def restart():



num=[0 for i in range(9)]
board=[" " for i in range(9)]
a=2
start(board,a,num)


def wincheck(t):



for i in range(8):
if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
if t[win[i][0]]=="X":
print("Player 1 wins")
else:
print("Player 2 wins")
playa = input("Do you want to play again? Y/N")
if playa.lower() == "y":
restart()
else:
exit(0)


def display_board(t,a,num):



print( " "*3+'|'+" "*3+'|'+" "*3) 
print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
print( " "*3+'|'+" "*3+'|'+" "*3)
print("-"*11)
print( " "*3+'|'+" "*3+'|'+" "*3)
print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
print( " "*3+'|'+" "*3+'|'+" "*3)
wincheck(t)
if 0 not in num:
print("Draw")
restart()
start(t,a,num)


def start(board,a,num):



if a%2==0:
p1n=int(input("Player 1, Enter a number from 1 to 9"))
if p1n not in num:
num[p1n-1]=p1n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p1n-1]="X"
a=a+1
display_board(board,a,num)
else:
p2n=int(input("Player 2, Enter a number from 1 to 9"))
if p2n not in num:
num[p2n-1]=p2n
print(num)
else:
print("Please enter in a free space")
start(board,a,num)
board[p2n-1]="O"
a=a+1
display_board(board,a,num)


a=2



board=[" " for i in range(9)]



num=[0 for i in range(9)]



win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



start(board,a,num)









share







New contributor




Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$


















    0












    $begingroup$


    I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



    def restart():



    num=[0 for i in range(9)]
    board=[" " for i in range(9)]
    a=2
    start(board,a,num)


    def wincheck(t):



    for i in range(8):
    if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
    t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
    if t[win[i][0]]=="X":
    print("Player 1 wins")
    else:
    print("Player 2 wins")
    playa = input("Do you want to play again? Y/N")
    if playa.lower() == "y":
    restart()
    else:
    exit(0)


    def display_board(t,a,num):



    print( " "*3+'|'+" "*3+'|'+" "*3) 
    print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("-"*11)
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("-"*11)
    print( " "*3+'|'+" "*3+'|'+" "*3)
    print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
    print( " "*3+'|'+" "*3+'|'+" "*3)
    wincheck(t)
    if 0 not in num:
    print("Draw")
    restart()
    start(t,a,num)


    def start(board,a,num):



    if a%2==0:
    p1n=int(input("Player 1, Enter a number from 1 to 9"))
    if p1n not in num:
    num[p1n-1]=p1n
    print(num)
    else:
    print("Please enter in a free space")
    start(board,a,num)
    board[p1n-1]="X"
    a=a+1
    display_board(board,a,num)
    else:
    p2n=int(input("Player 2, Enter a number from 1 to 9"))
    if p2n not in num:
    num[p2n-1]=p2n
    print(num)
    else:
    print("Please enter in a free space")
    start(board,a,num)
    board[p2n-1]="O"
    a=a+1
    display_board(board,a,num)


    a=2



    board=[" " for i in range(9)]



    num=[0 for i in range(9)]



    win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



    start(board,a,num)









    share







    New contributor




    Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



      def restart():



      num=[0 for i in range(9)]
      board=[" " for i in range(9)]
      a=2
      start(board,a,num)


      def wincheck(t):



      for i in range(8):
      if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
      t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
      if t[win[i][0]]=="X":
      print("Player 1 wins")
      else:
      print("Player 2 wins")
      playa = input("Do you want to play again? Y/N")
      if playa.lower() == "y":
      restart()
      else:
      exit(0)


      def display_board(t,a,num):



      print( " "*3+'|'+" "*3+'|'+" "*3) 
      print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      wincheck(t)
      if 0 not in num:
      print("Draw")
      restart()
      start(t,a,num)


      def start(board,a,num):



      if a%2==0:
      p1n=int(input("Player 1, Enter a number from 1 to 9"))
      if p1n not in num:
      num[p1n-1]=p1n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p1n-1]="X"
      a=a+1
      display_board(board,a,num)
      else:
      p2n=int(input("Player 2, Enter a number from 1 to 9"))
      if p2n not in num:
      num[p2n-1]=p2n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p2n-1]="O"
      a=a+1
      display_board(board,a,num)


      a=2



      board=[" " for i in range(9)]



      num=[0 for i in range(9)]



      win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



      start(board,a,num)









      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I have written a code for a tic-tac-toe game and it works well. But, I don't know whether it is an efficient one. Any help on how to optimize it?



      def restart():



      num=[0 for i in range(9)]
      board=[" " for i in range(9)]
      a=2
      start(board,a,num)


      def wincheck(t):



      for i in range(8):
      if t[win[i][0]]==t[win[i][1]] and t[win[i][0]]==t[win[i][2]] and
      t[win[i][1]]==t[win[i][2]] and t[win[i][0]]!=" ":
      if t[win[i][0]]=="X":
      print("Player 1 wins")
      else:
      print("Player 2 wins")
      playa = input("Do you want to play again? Y/N")
      if playa.lower() == "y":
      restart()
      else:
      exit(0)


      def display_board(t,a,num):



      print( " "*3+'|'+" "*3+'|'+" "*3) 
      print("0:^3|1:^3|2:^3".format(t[6],t[7],t[8]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[3],t[4],t[5]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("-"*11)
      print( " "*3+'|'+" "*3+'|'+" "*3)
      print("0:^3|1:^3|2:^3".format(t[0],t[1],t[2]))
      print( " "*3+'|'+" "*3+'|'+" "*3)
      wincheck(t)
      if 0 not in num:
      print("Draw")
      restart()
      start(t,a,num)


      def start(board,a,num):



      if a%2==0:
      p1n=int(input("Player 1, Enter a number from 1 to 9"))
      if p1n not in num:
      num[p1n-1]=p1n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p1n-1]="X"
      a=a+1
      display_board(board,a,num)
      else:
      p2n=int(input("Player 2, Enter a number from 1 to 9"))
      if p2n not in num:
      num[p2n-1]=p2n
      print(num)
      else:
      print("Please enter in a free space")
      start(board,a,num)
      board[p2n-1]="O"
      a=a+1
      display_board(board,a,num)


      a=2



      board=[" " for i in range(9)]



      num=[0 for i in range(9)]



      win = [[0,1,2],[3,4,5],[6,7,8],[0,4,8],[6,4,2],[6,3,0],[7,4,1],[8,5,2]]



      start(board,a,num)







      python-3.x tic-tac-toe





      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 2 mins ago









      IrfanIrfan

      1




      1




      New contributor




      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Irfan is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Irfan is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Irfan is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Irfan is a new contributor. Be nice, and check out our Code of Conduct.












          Irfan is a new contributor. Be nice, and check out our Code of Conduct.











          Irfan is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216967%2fhow-to-write-an-efficient-code-for-the-following-tic-tac-toe-game%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि