merge two sorted list in a decent solution but get low scores

The baby cries all morning

What is the oldest known work of fiction?

Student evaluations of teaching assistants

How do I define a right arrow with bar in LaTeX?

is this a spam?

What would happen if the UK refused to take part in EU Parliamentary elections?

What does this 7 mean above the f flat

Can a monster with multiattack use this ability if they are missing a limb?

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

Do there exist finite commutative rings with identity that are not Bézout rings?

Will it be accepted, if there is no ''Main Character" stereotype?

Is there a good way to store credentials outside of a password manager?

when is out of tune ok?

Implement the Thanos sorting algorithm

Why did Kant, Hegel, and Adorno leave some words and phrases in the Greek alphabet?

Is this Spell Mimic feat balanced?

How do I rename a LINUX host without needing to reboot for the rename to take effect?

How can I get through very long and very dry, but also very useful technical documents when learning a new tool?

Hide Select Output from T-SQL

Valid Badminton Score?

How could Frankenstein get the parts for his _second_ creature?

Can criminal fraud exist without damages?

How does it work when somebody invests in my business?

Why does John Bercow say “unlock” after reading out the results of a vote?



merge two sorted list in a decent solution but get low scores














0












$begingroup$


I tried to solve a merge two sorted list problem in leetcodes




 Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.



Example:



Input: 1->2->4, 1->3->4
Output: 1->1->2->3->4->4



class Solution:
def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
"""
Plan:
Compare l1 and l2 and merge the remainders
"""
l3_head = ListNode(0)
l3_cur = l3_head

while l1 and l2: #assert both exist
if l2.val < l1.val:
l3_cur.next = l2 #build l3's node
l2 = l2.next #this is i++
else:
l3_cur.next = l1
l1 = l1.next
l3_cur = l3_cur.next #find the next to build
if l1:
l3_cur.next = l1
if l2:
l3_cur.next = l2

return l3_head.next


I assumed this is a decent solution but got



>




Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.



Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.



Next challenges:




How could improve my solution?









share







New contributor




Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    I tried to solve a merge two sorted list problem in leetcodes




     Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.



    Example:



    Input: 1->2->4, 1->3->4
    Output: 1->1->2->3->4->4



    class Solution:
    def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
    """
    Plan:
    Compare l1 and l2 and merge the remainders
    """
    l3_head = ListNode(0)
    l3_cur = l3_head

    while l1 and l2: #assert both exist
    if l2.val < l1.val:
    l3_cur.next = l2 #build l3's node
    l2 = l2.next #this is i++
    else:
    l3_cur.next = l1
    l1 = l1.next
    l3_cur = l3_cur.next #find the next to build
    if l1:
    l3_cur.next = l1
    if l2:
    l3_cur.next = l2

    return l3_head.next


    I assumed this is a decent solution but got



    >




    Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.



    Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.



    Next challenges:




    How could improve my solution?









    share







    New contributor




    Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      I tried to solve a merge two sorted list problem in leetcodes




       Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.



      Example:



      Input: 1->2->4, 1->3->4
      Output: 1->1->2->3->4->4



      class Solution:
      def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
      """
      Plan:
      Compare l1 and l2 and merge the remainders
      """
      l3_head = ListNode(0)
      l3_cur = l3_head

      while l1 and l2: #assert both exist
      if l2.val < l1.val:
      l3_cur.next = l2 #build l3's node
      l2 = l2.next #this is i++
      else:
      l3_cur.next = l1
      l1 = l1.next
      l3_cur = l3_cur.next #find the next to build
      if l1:
      l3_cur.next = l1
      if l2:
      l3_cur.next = l2

      return l3_head.next


      I assumed this is a decent solution but got



      >




      Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.



      Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.



      Next challenges:




      How could improve my solution?









      share







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      I tried to solve a merge two sorted list problem in leetcodes




       Merge two sorted linked lists and return it as a new list. The new list should be made by splicing together the nodes of the first two lists.



      Example:



      Input: 1->2->4, 1->3->4
      Output: 1->1->2->3->4->4



      class Solution:
      def mergeTwoLists(self, l1: ListNode, l2: ListNode) -> ListNode:
      """
      Plan:
      Compare l1 and l2 and merge the remainders
      """
      l3_head = ListNode(0)
      l3_cur = l3_head

      while l1 and l2: #assert both exist
      if l2.val < l1.val:
      l3_cur.next = l2 #build l3's node
      l2 = l2.next #this is i++
      else:
      l3_cur.next = l1
      l1 = l1.next
      l3_cur = l3_cur.next #find the next to build
      if l1:
      l3_cur.next = l1
      if l2:
      l3_cur.next = l2

      return l3_head.next


      I assumed this is a decent solution but got



      >




      Runtime: 56 ms, faster than 23.98% of Python3 online submissions for Merge Two Sorted Lists.



      Memory Usage: 13.1 MB, less than 5.06% of Python3 online submissions for Merge Two Sorted Lists.



      Next challenges:




      How could improve my solution?







      python





      share







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 min ago









      AliceAlice

      1764




      1764




      New contributor




      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Alice is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Alice is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216312%2fmerge-two-sorted-list-in-a-decent-solution-but-get-low-scores%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Alice is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Alice is a new contributor. Be nice, and check out our Code of Conduct.












          Alice is a new contributor. Be nice, and check out our Code of Conduct.











          Alice is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216312%2fmerge-two-sorted-list-in-a-decent-solution-but-get-low-scores%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि