Is this a good code for implementation of Radix Sort algorithm for sorting integers in c++? The Next CEO of Stack OverflowImproving performance when sorting array of structs by multiple fieldsSorting millions of integersAdaptive counting sort for integer arrays in JavaExact sort - sorting with few move operationsImplement LSD radix sort in pythonSpaceSort - A new sorting algorithmRadix sort implementationCompare 2 unordered, rooted trees for shape-isomorphismFollow-up 1: Compare 2 unordered, rooted trees for shape-isomorphismC++ - Radix sort implementation

How do I go from 300 unfinished/half written blog posts, to published posts?

Anatomically Correct Strange Women In Ponds Distributing Swords

How to make a variable always equal to the result of some calculations?

Unreliable Magic - Is it worth it?

How long to clear the 'suck zone' of a turbofan after start is initiated?

Why do remote companies require working in the US?

Implement the Thanos sorting algorithm

Can I equip Skullclamp on a creature I am sacrificing?

How to Reset Passwords on Multiple Websites Easily?

Should I tutor a student who I know has cheated on their homework?

What's the point of interval inversion?

Return the Closest Prime Number

How to use tikz in fbox?

Natural language into sentence logic

Why doesn't a table tennis ball float on the surface? How do we calculate buoyancy here?

Is it okay to store user locations?

How can I get through very long and very dry, but also very useful technical documents when learning a new tool?

Term for the "extreme-extension" version of a straw man fallacy?

How to write papers efficiently when English isn't my first language?

How should I support this large drywall patch?

Is it safe to use c_str() on a temporary string?

How did people program for Consoles with multiple CPUs?

Visit to the USA with ESTA approved before trip to Iran

Describing a person. What needs to be mentioned?



Is this a good code for implementation of Radix Sort algorithm for sorting integers in c++?



The Next CEO of Stack OverflowImproving performance when sorting array of structs by multiple fieldsSorting millions of integersAdaptive counting sort for integer arrays in JavaExact sort - sorting with few move operationsImplement LSD radix sort in pythonSpaceSort - A new sorting algorithmRadix sort implementationCompare 2 unordered, rooted trees for shape-isomorphismFollow-up 1: Compare 2 unordered, rooted trees for shape-isomorphismC++ - Radix sort implementation










0












$begingroup$


Wrote code for Radix Sort algorithm for number sorting.
Just curious to know if it is good.. I am open for discussion and improvements.
Any review is highly appreciated.




You can also view and run/test the code here Radix Sort




#include<iostream>
using namespace std;

int getNumberAtPosition(int num,int position)
return (num/position)%10;

void radixSort(int array[],int length)
int sizeOfEachBucket = length;
int numberOfBuckets = 10;
int buckets[10][sizeOfEachBucket];
int large = 0;
int maxPasses = 0;
//finding largest number from array
for(int i=0; i<length; i++)
if(array[i]>large)
large = array[i];



//finding the number of passes
while(large != 0)
maxPasses++;
large = large/10;

cout<<"Max passes ="<<maxPasses<<endl;
int position = 1;
int bucketIndex = 0;
int newListIndex = 0;
int arrayLengths[10];
for(int i=0; i<maxPasses; i++)
//cout<<"i ="<<i<<endl;
for(int k=0; k<=9; k++)
//cout<<"k ="<<k<<endl;
bucketIndex = 0;
for(int j=0; j<length; j++)
if(k==getNumberAtPosition(array[j],position))
buckets[k][bucketIndex] = array[j];
bucketIndex++;


arrayLengths[k] = bucketIndex;

position = position*10;
int newArrayIndex = 0;
for(int k=0; k<=9; k++)
//cout<<"k ="<<k<<endl;
bucketIndex = 0;
for(int x=0; x<arrayLengths[k];x++)
array[newArrayIndex] = buckets[k][x];
newArrayIndex++;




for(int i=0; i<length; i++)
cout<<array[i]<<"t";










share









$endgroup$
















    0












    $begingroup$


    Wrote code for Radix Sort algorithm for number sorting.
    Just curious to know if it is good.. I am open for discussion and improvements.
    Any review is highly appreciated.




    You can also view and run/test the code here Radix Sort




    #include<iostream>
    using namespace std;

    int getNumberAtPosition(int num,int position)
    return (num/position)%10;

    void radixSort(int array[],int length)
    int sizeOfEachBucket = length;
    int numberOfBuckets = 10;
    int buckets[10][sizeOfEachBucket];
    int large = 0;
    int maxPasses = 0;
    //finding largest number from array
    for(int i=0; i<length; i++)
    if(array[i]>large)
    large = array[i];



    //finding the number of passes
    while(large != 0)
    maxPasses++;
    large = large/10;

    cout<<"Max passes ="<<maxPasses<<endl;
    int position = 1;
    int bucketIndex = 0;
    int newListIndex = 0;
    int arrayLengths[10];
    for(int i=0; i<maxPasses; i++)
    //cout<<"i ="<<i<<endl;
    for(int k=0; k<=9; k++)
    //cout<<"k ="<<k<<endl;
    bucketIndex = 0;
    for(int j=0; j<length; j++)
    if(k==getNumberAtPosition(array[j],position))
    buckets[k][bucketIndex] = array[j];
    bucketIndex++;


    arrayLengths[k] = bucketIndex;

    position = position*10;
    int newArrayIndex = 0;
    for(int k=0; k<=9; k++)
    //cout<<"k ="<<k<<endl;
    bucketIndex = 0;
    for(int x=0; x<arrayLengths[k];x++)
    array[newArrayIndex] = buckets[k][x];
    newArrayIndex++;




    for(int i=0; i<length; i++)
    cout<<array[i]<<"t";










    share









    $endgroup$














      0












      0








      0





      $begingroup$


      Wrote code for Radix Sort algorithm for number sorting.
      Just curious to know if it is good.. I am open for discussion and improvements.
      Any review is highly appreciated.




      You can also view and run/test the code here Radix Sort




      #include<iostream>
      using namespace std;

      int getNumberAtPosition(int num,int position)
      return (num/position)%10;

      void radixSort(int array[],int length)
      int sizeOfEachBucket = length;
      int numberOfBuckets = 10;
      int buckets[10][sizeOfEachBucket];
      int large = 0;
      int maxPasses = 0;
      //finding largest number from array
      for(int i=0; i<length; i++)
      if(array[i]>large)
      large = array[i];



      //finding the number of passes
      while(large != 0)
      maxPasses++;
      large = large/10;

      cout<<"Max passes ="<<maxPasses<<endl;
      int position = 1;
      int bucketIndex = 0;
      int newListIndex = 0;
      int arrayLengths[10];
      for(int i=0; i<maxPasses; i++)
      //cout<<"i ="<<i<<endl;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int j=0; j<length; j++)
      if(k==getNumberAtPosition(array[j],position))
      buckets[k][bucketIndex] = array[j];
      bucketIndex++;


      arrayLengths[k] = bucketIndex;

      position = position*10;
      int newArrayIndex = 0;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int x=0; x<arrayLengths[k];x++)
      array[newArrayIndex] = buckets[k][x];
      newArrayIndex++;




      for(int i=0; i<length; i++)
      cout<<array[i]<<"t";










      share









      $endgroup$




      Wrote code for Radix Sort algorithm for number sorting.
      Just curious to know if it is good.. I am open for discussion and improvements.
      Any review is highly appreciated.




      You can also view and run/test the code here Radix Sort




      #include<iostream>
      using namespace std;

      int getNumberAtPosition(int num,int position)
      return (num/position)%10;

      void radixSort(int array[],int length)
      int sizeOfEachBucket = length;
      int numberOfBuckets = 10;
      int buckets[10][sizeOfEachBucket];
      int large = 0;
      int maxPasses = 0;
      //finding largest number from array
      for(int i=0; i<length; i++)
      if(array[i]>large)
      large = array[i];



      //finding the number of passes
      while(large != 0)
      maxPasses++;
      large = large/10;

      cout<<"Max passes ="<<maxPasses<<endl;
      int position = 1;
      int bucketIndex = 0;
      int newListIndex = 0;
      int arrayLengths[10];
      for(int i=0; i<maxPasses; i++)
      //cout<<"i ="<<i<<endl;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int j=0; j<length; j++)
      if(k==getNumberAtPosition(array[j],position))
      buckets[k][bucketIndex] = array[j];
      bucketIndex++;


      arrayLengths[k] = bucketIndex;

      position = position*10;
      int newArrayIndex = 0;
      for(int k=0; k<=9; k++)
      //cout<<"k ="<<k<<endl;
      bucketIndex = 0;
      for(int x=0; x<arrayLengths[k];x++)
      array[newArrayIndex] = buckets[k][x];
      newArrayIndex++;




      for(int i=0; i<length; i++)
      cout<<array[i]<<"t";








      c++ algorithm sorting





      share












      share










      share



      share










      asked 3 mins ago









      DeepeshkumarDeepeshkumar

      61




      61




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216460%2fis-this-a-good-code-for-implementation-of-radix-sort-algorithm-for-sorting-integ%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















          draft saved

          draft discarded
















































          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216460%2fis-this-a-good-code-for-implementation-of-radix-sort-algorithm-for-sorting-integ%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि