[Beginner]/[Readability]: How much does my code suck?Generating a topographic stringFizzBuzz for CodeEvalPE # 34 - “Digit Factorials” with no loopsHackerrank Inherited CodeEquation EvaluatorDisplay Fibonacci numbersHackerrank ransomnoteFrequency Queries hackerrankGuess-the-number game by a Python beginnerHackerrank All Women's Codesprint 2019: Name the Product

The screen of my macbook suddenly broken down how can I do to recover

Does a 'pending' US visa application constitute a denial?

Is there a name for this algorithm to calculate the concentration of a mixture of two solutions containing the same solute?

Why did the EU agree to delay the Brexit deadline?

Redundant comparison & "if" before assignment

Why does the Sun have different day lengths, but not the gas giants?

Melting point of aspirin, contradicting sources

Offered money to buy a house, seller is asking for more to cover gap between their listing and mortgage owed

How to bake one texture for one mesh with multiple textures blender 2.8

Lowest total scrabble score

What is this called? Old film camera viewer?

What was the exact wording from Ivanhoe of this advice on how to free yourself from slavery?

dpdt switch to spst switch

How do you respond to a colleague from another team when they're wrongly expecting that you'll help them?

Why can Carol Danvers change her suit colours in the first place?

Electoral considerations aside, what are potential benefits, for the US, of policy changes proposed by the tweet recognizing Golan annexation?

Which one is correct as adjective “protruding” or “protruded”?

Multiplicative persistence

250 Floor Tower

Reverse int within the 32-bit signed integer range: [−2^31, 2^31 − 1]

Why Shazam when there is already Superman?

Is there any references on the tensor product of presentable (1-)categories?

Does an advisor owe his/her student anything? Will an advisor keep a PhD student only out of pity?

Pre-mixing cryogenic fuels and using only one fuel tank



[Beginner]/[Readability]: How much does my code suck?


Generating a topographic stringFizzBuzz for CodeEvalPE # 34 - “Digit Factorials” with no loopsHackerrank Inherited CodeEquation EvaluatorDisplay Fibonacci numbersHackerrank ransomnoteFrequency Queries hackerrankGuess-the-number game by a Python beginnerHackerrank All Women's Codesprint 2019: Name the Product













0












$begingroup$


Completed a short coding challenge located here:
https://www.hackerrank.com/challenges/js10-loops/problem?h_r=next-challenge&h_v=zen&h_r=next-challenge&h_v=zen



Just want to have it checked to see what I could have done to make it better and more readable.



 /*
*
* Complete the vowelsAndConsonants function.
* Print your output using 'console.log()'.
*/
function vowelsAndConsonants(s)
var strConsonants = "";
var strVowels = "";
var i;

for (i in s)
s.charAt(i) == "o"

// console.log(strVowels);

i = 0;
for (i in strVowels)
console.log(strVowels.charAt(i));


// console.log(strConsonants);

i = 0;
for (i in strConsonants)
console.log(strConsonants.charAt(i));











share







New contributor




Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    Completed a short coding challenge located here:
    https://www.hackerrank.com/challenges/js10-loops/problem?h_r=next-challenge&h_v=zen&h_r=next-challenge&h_v=zen



    Just want to have it checked to see what I could have done to make it better and more readable.



     /*
    *
    * Complete the vowelsAndConsonants function.
    * Print your output using 'console.log()'.
    */
    function vowelsAndConsonants(s)
    var strConsonants = "";
    var strVowels = "";
    var i;

    for (i in s)
    s.charAt(i) == "o"

    // console.log(strVowels);

    i = 0;
    for (i in strVowels)
    console.log(strVowels.charAt(i));


    // console.log(strConsonants);

    i = 0;
    for (i in strConsonants)
    console.log(strConsonants.charAt(i));











    share







    New contributor




    Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      Completed a short coding challenge located here:
      https://www.hackerrank.com/challenges/js10-loops/problem?h_r=next-challenge&h_v=zen&h_r=next-challenge&h_v=zen



      Just want to have it checked to see what I could have done to make it better and more readable.



       /*
      *
      * Complete the vowelsAndConsonants function.
      * Print your output using 'console.log()'.
      */
      function vowelsAndConsonants(s)
      var strConsonants = "";
      var strVowels = "";
      var i;

      for (i in s)
      s.charAt(i) == "o"

      // console.log(strVowels);

      i = 0;
      for (i in strVowels)
      console.log(strVowels.charAt(i));


      // console.log(strConsonants);

      i = 0;
      for (i in strConsonants)
      console.log(strConsonants.charAt(i));











      share







      New contributor




      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      Completed a short coding challenge located here:
      https://www.hackerrank.com/challenges/js10-loops/problem?h_r=next-challenge&h_v=zen&h_r=next-challenge&h_v=zen



      Just want to have it checked to see what I could have done to make it better and more readable.



       /*
      *
      * Complete the vowelsAndConsonants function.
      * Print your output using 'console.log()'.
      */
      function vowelsAndConsonants(s)
      var strConsonants = "";
      var strVowels = "";
      var i;

      for (i in s)
      s.charAt(i) == "o"

      // console.log(strVowels);

      i = 0;
      for (i in strVowels)
      console.log(strVowels.charAt(i));


      // console.log(strConsonants);

      i = 0;
      for (i in strConsonants)
      console.log(strConsonants.charAt(i));









      javascript beginner





      share







      New contributor




      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 1 min ago









      Jacob FranklinJacob Franklin

      1




      1




      New contributor




      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Jacob Franklin is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes











          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216086%2fbeginner-readability-how-much-does-my-code-suck%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.












          Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.











          Jacob Franklin is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216086%2fbeginner-readability-how-much-does-my-code-suck%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि