VBA Performance Deficiency in Nested Loops

How much of data wrangling is a data scientist's job?

One verb to replace 'be a member of' a club

What do you call someone who asks many questions?

Can we compute the area of a quadrilateral with one right angle when we only know the lengths of any three sides?

Should I tell management that I intend to leave due to bad software development practices?

ssTTsSTtRrriinInnnnNNNIiinngg

Should I cover my bicycle overnight while bikepacking?

Why is it a bad idea to hire a hitman to eliminate most corrupt politicians?

Is it logically or scientifically possible to artificially send energy to the body?

Can I run a new neutral wire to repair a broken circuit?

What method can I use to design a dungeon difficult enough that the PCs can't make it through without killing them?

Determining Impedance With An Antenna Analyzer

Examples of smooth manifolds admitting inbetween one and a continuum of complex structures

Why is this clock signal connected to a capacitor to gnd?

Cursor Replacement for Newbies

How to show a landlord what we have in savings?

How do conventional missiles fly?

How would I stat a creature to be immune to everything but the Magic Missile spell? (just for fun)

iPad being using in wall mount battery swollen

Unable to supress ligatures in headings which are set in Caps

Venezuelan girlfriend wants to travel the USA to be with me. What is the process?

Why is consensus so controversial in Britain?

What is the idiomatic way to say "clothing fits"?

Unlock My Phone! February 2018



VBA Performance Deficiency in Nested Loops














0












$begingroup$


The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?



All suggestions and improvements will be highly appreciated.



Code:



Sub FillStandardHours()
'
' FillStandardHours Macro
'

Application.ScreenUpdating = False
Application.DisplayStatusBar = False
Application.Calculation = xlCalculationManual
Application.EnableEvents = False


Dim CurrentSheet, StandRosSheet As Worksheet
Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
Dim a, b, c, d, DayNum As Integer
Dim EndLoop1, EndLoop2 As Boolean


Set CurrentSheet = Sheets(ActiveSheet.Name)
CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

Set StandRosSheet = Sheets("Standard Roster")
StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

CurrentSheet.DisplayPageBreaks = False
StandRosSheet.DisplayPageBreaks = False

a = 9

Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet

b = 8
EndLoop1 = False

Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then

c = 7
Do Until c = CurrentSheetLastColumn + 1

d = 8
DayNum = CurrentSheet.Cells(6, c).Value
Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
If StandRosSheet.Cells(7, d).Value <> DayNum Then
d = d + 1
End If

If d = 22 Then
MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
Exit Sub
End If
Loop

If IsEmpty(CurrentSheet.Cells(8, c)) Then
c = c + 1
Else:

If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
CurrentSheet.Cells(a, c).Value = "NR"
ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
CurrentSheet.Cells(a, c).Value = "WFH"
Else: CurrentSheet.Cells(a, c).Value = "STD"
End If

c = c + 1

End If
Loop

EndLoop1 = True

Else: b = b + 1
End If
Loop

a = a + 1
Loop

CurrentSheet.DisplayPageBreaks = True
StandRosSheet.DisplayPageBreaks = True

Application.ScreenUpdating = True
Application.DisplayStatusBar = True
Application.Calculation = xlCalculationAutomatic
Application.EnableEvents = True

'
End Sub








share







New contributor




Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.







$endgroup$
















    0












    $begingroup$


    The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?



    All suggestions and improvements will be highly appreciated.



    Code:



    Sub FillStandardHours()
    '
    ' FillStandardHours Macro
    '

    Application.ScreenUpdating = False
    Application.DisplayStatusBar = False
    Application.Calculation = xlCalculationManual
    Application.EnableEvents = False


    Dim CurrentSheet, StandRosSheet As Worksheet
    Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
    Dim a, b, c, d, DayNum As Integer
    Dim EndLoop1, EndLoop2 As Boolean


    Set CurrentSheet = Sheets(ActiveSheet.Name)
    CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
    CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

    Set StandRosSheet = Sheets("Standard Roster")
    StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
    StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

    CurrentSheet.DisplayPageBreaks = False
    StandRosSheet.DisplayPageBreaks = False

    a = 9

    Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet

    b = 8
    EndLoop1 = False

    Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
    If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then

    c = 7
    Do Until c = CurrentSheetLastColumn + 1

    d = 8
    DayNum = CurrentSheet.Cells(6, c).Value
    Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
    If StandRosSheet.Cells(7, d).Value <> DayNum Then
    d = d + 1
    End If

    If d = 22 Then
    MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
    Exit Sub
    End If
    Loop

    If IsEmpty(CurrentSheet.Cells(8, c)) Then
    c = c + 1
    Else:

    If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
    CurrentSheet.Cells(a, c).Value = "NR"
    ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
    CurrentSheet.Cells(a, c).Value = "WFH"
    Else: CurrentSheet.Cells(a, c).Value = "STD"
    End If

    c = c + 1

    End If
    Loop

    EndLoop1 = True

    Else: b = b + 1
    End If
    Loop

    a = a + 1
    Loop

    CurrentSheet.DisplayPageBreaks = True
    StandRosSheet.DisplayPageBreaks = True

    Application.ScreenUpdating = True
    Application.DisplayStatusBar = True
    Application.Calculation = xlCalculationAutomatic
    Application.EnableEvents = True

    '
    End Sub








    share







    New contributor




    Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
    Check out our Code of Conduct.







    $endgroup$














      0












      0








      0





      $begingroup$


      The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?



      All suggestions and improvements will be highly appreciated.



      Code:



      Sub FillStandardHours()
      '
      ' FillStandardHours Macro
      '

      Application.ScreenUpdating = False
      Application.DisplayStatusBar = False
      Application.Calculation = xlCalculationManual
      Application.EnableEvents = False


      Dim CurrentSheet, StandRosSheet As Worksheet
      Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
      Dim a, b, c, d, DayNum As Integer
      Dim EndLoop1, EndLoop2 As Boolean


      Set CurrentSheet = Sheets(ActiveSheet.Name)
      CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
      CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

      Set StandRosSheet = Sheets("Standard Roster")
      StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
      StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

      CurrentSheet.DisplayPageBreaks = False
      StandRosSheet.DisplayPageBreaks = False

      a = 9

      Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet

      b = 8
      EndLoop1 = False

      Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
      If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then

      c = 7
      Do Until c = CurrentSheetLastColumn + 1

      d = 8
      DayNum = CurrentSheet.Cells(6, c).Value
      Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
      If StandRosSheet.Cells(7, d).Value <> DayNum Then
      d = d + 1
      End If

      If d = 22 Then
      MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
      Exit Sub
      End If
      Loop

      If IsEmpty(CurrentSheet.Cells(8, c)) Then
      c = c + 1
      Else:

      If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
      CurrentSheet.Cells(a, c).Value = "NR"
      ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
      CurrentSheet.Cells(a, c).Value = "WFH"
      Else: CurrentSheet.Cells(a, c).Value = "STD"
      End If

      c = c + 1

      End If
      Loop

      EndLoop1 = True

      Else: b = b + 1
      End If
      Loop

      a = a + 1
      Loop

      CurrentSheet.DisplayPageBreaks = True
      StandRosSheet.DisplayPageBreaks = True

      Application.ScreenUpdating = True
      Application.DisplayStatusBar = True
      Application.Calculation = xlCalculationAutomatic
      Application.EnableEvents = True

      '
      End Sub








      share







      New contributor




      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.







      $endgroup$




      The below code works however it takes several minutes to run. Is there a way to optimise performance so that it can be completed in a shorter amount of time?



      All suggestions and improvements will be highly appreciated.



      Code:



      Sub FillStandardHours()
      '
      ' FillStandardHours Macro
      '

      Application.ScreenUpdating = False
      Application.DisplayStatusBar = False
      Application.Calculation = xlCalculationManual
      Application.EnableEvents = False


      Dim CurrentSheet, StandRosSheet As Worksheet
      Dim CurrentSheetLastColumn, CurrentSheetLastRow, StandRosLastColumn, StandRosLastRow As Integer
      Dim a, b, c, d, DayNum As Integer
      Dim EndLoop1, EndLoop2 As Boolean


      Set CurrentSheet = Sheets(ActiveSheet.Name)
      CurrentSheetLastColumn = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
      CurrentSheetLastRow = CurrentSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

      Set StandRosSheet = Sheets("Standard Roster")
      StandRosLastColumn = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Column
      StandRosLastRow = StandRosSheet.Cells.SpecialCells(xlCellTypeLastCell).Row

      CurrentSheet.DisplayPageBreaks = False
      StandRosSheet.DisplayPageBreaks = False

      a = 9

      Do Until a = CurrentSheetLastRow + 1 'Go through every name on CurrentSheet

      b = 8
      EndLoop1 = False

      Do Until b = StandRosLastRow + 1 Or EndLoop1 = True 'For every name on CurrentSheet, go through every name on Standard Roster
      If StandRosSheet.Cells(b, 3).Value = CurrentSheet.Cells(a, 3).Value Then

      c = 7
      Do Until c = CurrentSheetLastColumn + 1

      d = 8
      DayNum = CurrentSheet.Cells(6, c).Value
      Do Until StandRosSheet.Cells(7, d).Value = DayNum Or d = 22
      If StandRosSheet.Cells(7, d).Value <> DayNum Then
      d = d + 1
      End If

      If d = 22 Then
      MsgBox "Error: " & DayNum & " in " & CurrentSheet.Name & " worksheet does not correspond to the Standard Roster", vbOKOnly, "Error Filling " & CurrentSheet.Name & " with Standard Roster"
      Exit Sub
      End If
      Loop

      If IsEmpty(CurrentSheet.Cells(8, c)) Then
      c = c + 1
      Else:

      If CurrentSheet.Cells(8, c).Value < StandRosSheet.Cells(b, d).Offset(1, 0).Value Or CurrentSheet.Cells(8, c).Value > StandRosSheet.Cells(b, d).Offset(2, 0).Value Or (IsEmpty(StandRosSheet.Cells(b, d).Offset(1, 0).Value) And IsEmpty(StandRosSheet.Cells(b, d).Offset(2, 0).Value)) Then
      CurrentSheet.Cells(a, c).Value = "NR"
      ElseIf StandRosSheet.Cells(b, d).Offset(4, 0).Value = "WFH" Then
      CurrentSheet.Cells(a, c).Value = "WFH"
      Else: CurrentSheet.Cells(a, c).Value = "STD"
      End If

      c = c + 1

      End If
      Loop

      EndLoop1 = True

      Else: b = b + 1
      End If
      Loop

      a = a + 1
      Loop

      CurrentSheet.DisplayPageBreaks = True
      StandRosSheet.DisplayPageBreaks = True

      Application.ScreenUpdating = True
      Application.DisplayStatusBar = True
      Application.Calculation = xlCalculationAutomatic
      Application.EnableEvents = True

      '
      End Sub






      vba





      share







      New contributor




      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.










      share







      New contributor




      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.








      share



      share






      New contributor




      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.









      asked 24 secs ago









      Josh TJosh T

      1




      1




      New contributor




      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.





      New contributor





      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.






      Josh T is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
      Check out our Code of Conduct.




















          0






          active

          oldest

          votes












          Your Answer





          StackExchange.ifUsing("editor", function ()
          return StackExchange.using("mathjaxEditing", function ()
          StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
          StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
          );
          );
          , "mathjax-editing");

          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "196"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: false,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: null,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );






          Josh T is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216825%2fvba-performance-deficiency-in-nested-loops%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown

























          0






          active

          oldest

          votes








          0






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes








          Josh T is a new contributor. Be nice, and check out our Code of Conduct.









          draft saved

          draft discarded


















          Josh T is a new contributor. Be nice, and check out our Code of Conduct.












          Josh T is a new contributor. Be nice, and check out our Code of Conduct.











          Josh T is a new contributor. Be nice, and check out our Code of Conduct.














          Thanks for contributing an answer to Code Review Stack Exchange!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid


          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.

          Use MathJax to format equations. MathJax reference.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f216825%2fvba-performance-deficiency-in-nested-loops%23new-answer', 'question_page');

          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          कुँवर स्रोत दिक्चालन सूची"कुँवर""राणा कुँवरके वंशावली"

          Why is a white electrical wire connected to 2 black wires?How to wire a light fixture with 3 white wires in box?How should I wire a ceiling fan when there's only three wires in the box?Two white, two black, two ground, and red wire in ceiling box connected to switchWhy is there a white wire connected to multiple black wires in my light box?How to wire a light with two white wires and one black wireReplace light switch connected to a power outlet with dimmer - two black wires to one black and redHow to wire a light with multiple black/white/green wires from the ceiling?Ceiling box has 2 black and white wires but fan/ light only has 1 of eachWhy neutral wire connected to load wire?Switch with 2 black, 2 white, 2 ground and 1 red wire connected to ceiling light and a receptacle?

          चैत्य भूमि चित्र दीर्घा सन्दर्भ बाहरी कडियाँ दिक्चालन सूची"Chaitya Bhoomi""Chaitya Bhoomi: Statue of Equality in India""Dadar Chaitya Bhoomi: Statue of Equality in India""Ambedkar memorial: Centre okays transfer of Indu Mill land"चैत्यभमि