Vwwxrf

Is a naturally all "male" species possible?

Can I create an upright 7-foot × 5-foot wall with the Minor Illusion spell?

Would it be legal for a US State to ban exports of a natural resource?

How to color a zone in Tikz

How do I repair my stair bannister?

What does 사자 in this picture means?

Superhero words!

Can the electrostatic force be infinite in magnitude?

Who must act to prevent Brexit on March 29th?

Why are all the doors on Ferenginar (the Ferengi home world) far shorter than the average Ferengi?

Proving by induction of n. Is this correct until this point?

Should a half Jewish man be discouraged from marrying a Jewess?

The One-Electron Universe postulate is true - what simple change can I make to change the whole universe?

Partial sums of primes

What if somebody invests in my application?

Stereotypical names

Is there a good way to store credentials outside of a password manager?

I2C signal and power over long range (10meter cable)

A known event to a history junkie

What to do when my ideas aren't chosen, when I strongly disagree with the chosen solution?

Simulating a probability of 1 of 2^N with less than N random bits

For airliners, what prevents wing strikes on landing in bad weather?

What was required to accept "troll"?

Why isn't KTEX's runway designation 10/28 instead of 9/27?

Uni- and bidirectional pseudo-generic shortest path finders in C89

Finding Shortest PathFinding the shortest path in a graphShortest path through a mazeA* versus Bidirectional Dijkstra's algorithmShortest path in imageDijkstra's shortest path algorithm in CShortest knight pathShortest path in mazeC++ Dijkstra's shortest path implementationShortest path via intermediaries

0

$begingroup$

I have implemented two related shortest path algorithms for unweighted graphs in C89. My attempt was to learn some more idiomatic C constructs such as genericity (a client programmer should be able to plug in his/her graph data structures to the algorithms). Some questions:

1. Is it a good idea to embed the unit tests of a data type in the same *.c files?


2. Is it a good idea to do rather explicit type casting in order to make gcc -Wall -pendatic -ansi shut up?


3. Might the code below rely on an antipattern?

Code

bidirectional_breadth_first_search.c

#include "bidirectional_breadth_first_search.h"
#include "list.h"
#include "queue.h"
#include "utils.h"
#include <limits.h>

#define NEIGHBOR_NODE_ITERATOR_HAS_NEXT child_node_iterator_has_next
#define NEIGHBOR_NODE_ITERATOR_NEXT child_node_iterator_next

typedef child_node_iterator neighbor_node_iterator;

list* bidirectional_breadth_first_search(void* source_node,
 void* target_node,
 child_node_iterator* child_iterator,
 parent_node_iterator* parent_iterator,
 size_t (*hash_function)(void*),
 int (*equals_function)(void*, void*))
 !target_node
 

breadth_first_search.c

#include "breadth_first_search.h"
#include "directed_graph_node.h"
#include "queue.h"
#include "list.h"
#include "unordered_map.h"
#include "unordered_set.h"

static list* trace_back_path(void* target_node, unordered_map* parents)

 list* path = list_alloc(10);
 void* node = target_node;

 while (node)
 
 list_push_front(path, node);
 node = unordered_map_get(parents, node);
 

 return path;


list* breadth_first_search(void* source_node, 
 void* target_node,
 child_node_iterator* child_iterator,
 size_t (*hash_function) (void*),
 int (*equals_function) (void*, void*))
 !child_iterator
 

(The entire repository is here.)

c library pathfinding c89

share|improve this question

asked 10 mins ago

coderoddecoderodde

15.9k639129

$endgroup$

add a comment | 

0

$begingroup$

I have implemented two related shortest path algorithms for unweighted graphs in C89. My attempt was to learn some more idiomatic C constructs such as genericity (a client programmer should be able to plug in his/her graph data structures to the algorithms). Some questions:

1. Is it a good idea to embed the unit tests of a data type in the same *.c files?


2. Is it a good idea to do rather explicit type casting in order to make gcc -Wall -pendatic -ansi shut up?


3. Might the code below rely on an antipattern?

Code

bidirectional_breadth_first_search.c

#include "bidirectional_breadth_first_search.h"
#include "list.h"
#include "queue.h"
#include "utils.h"
#include <limits.h>

#define NEIGHBOR_NODE_ITERATOR_HAS_NEXT child_node_iterator_has_next
#define NEIGHBOR_NODE_ITERATOR_NEXT child_node_iterator_next

typedef child_node_iterator neighbor_node_iterator;

list* bidirectional_breadth_first_search(void* source_node,
 void* target_node,
 child_node_iterator* child_iterator,
 parent_node_iterator* parent_iterator,
 size_t (*hash_function)(void*),
 int (*equals_function)(void*, void*))
 !target_node
 

breadth_first_search.c

#include "breadth_first_search.h"
#include "directed_graph_node.h"
#include "queue.h"
#include "list.h"
#include "unordered_map.h"
#include "unordered_set.h"

static list* trace_back_path(void* target_node, unordered_map* parents)

 list* path = list_alloc(10);
 void* node = target_node;

 while (node)
 
 list_push_front(path, node);
 node = unordered_map_get(parents, node);
 

 return path;


list* breadth_first_search(void* source_node, 
 void* target_node,
 child_node_iterator* child_iterator,
 size_t (*hash_function) (void*),
 int (*equals_function) (void*, void*))
 !child_iterator
 

(The entire repository is here.)

c library pathfinding c89

share|improve this question

asked 10 mins ago

coderoddecoderodde

15.9k639129

$endgroup$

add a comment | 

$begingroup$

I have implemented two related shortest path algorithms for unweighted graphs in C89. My attempt was to learn some more idiomatic C constructs such as genericity (a client programmer should be able to plug in his/her graph data structures to the algorithms). Some questions:

1. Is it a good idea to embed the unit tests of a data type in the same *.c files?


2. Is it a good idea to do rather explicit type casting in order to make gcc -Wall -pendatic -ansi shut up?


3. Might the code below rely on an antipattern?

Code

bidirectional_breadth_first_search.c

#include "bidirectional_breadth_first_search.h"
#include "list.h"
#include "queue.h"
#include "utils.h"
#include <limits.h>

#define NEIGHBOR_NODE_ITERATOR_HAS_NEXT child_node_iterator_has_next
#define NEIGHBOR_NODE_ITERATOR_NEXT child_node_iterator_next

typedef child_node_iterator neighbor_node_iterator;

list* bidirectional_breadth_first_search(void* source_node,
 void* target_node,
 child_node_iterator* child_iterator,
 parent_node_iterator* parent_iterator,
 size_t (*hash_function)(void*),
 int (*equals_function)(void*, void*))
 !target_node
 

breadth_first_search.c

#include "breadth_first_search.h"
#include "directed_graph_node.h"
#include "queue.h"
#include "list.h"
#include "unordered_map.h"
#include "unordered_set.h"

static list* trace_back_path(void* target_node, unordered_map* parents)

 list* path = list_alloc(10);
 void* node = target_node;

 while (node)
 
 list_push_front(path, node);
 node = unordered_map_get(parents, node);
 

 return path;


list* breadth_first_search(void* source_node, 
 void* target_node,
 child_node_iterator* child_iterator,
 size_t (*hash_function) (void*),
 int (*equals_function) (void*, void*))
 !child_iterator
 

(The entire repository is here.)

c library pathfinding c89

share|improve this question

asked 10 mins ago

coderoddecoderodde

15.9k639129

$endgroup$

#include "bidirectional_breadth_first_search.h"
#include "list.h"
#include "queue.h"
#include "utils.h"
#include <limits.h>

#define NEIGHBOR_NODE_ITERATOR_HAS_NEXT child_node_iterator_has_next
#define NEIGHBOR_NODE_ITERATOR_NEXT child_node_iterator_next

typedef child_node_iterator neighbor_node_iterator;

list* bidirectional_breadth_first_search(void* source_node,
 void* target_node,
 child_node_iterator* child_iterator,
 parent_node_iterator* parent_iterator,
 size_t (*hash_function)(void*),
 int (*equals_function)(void*, void*))
 !target_node
 

#include "breadth_first_search.h"
#include "directed_graph_node.h"
#include "queue.h"
#include "list.h"
#include "unordered_map.h"
#include "unordered_set.h"

static list* trace_back_path(void* target_node, unordered_map* parents)

 list* path = list_alloc(10);
 void* node = target_node;

 while (node)
 
 list_push_front(path, node);
 node = unordered_map_get(parents, node);
 

 return path;


list* breadth_first_search(void* source_node, 
 void* target_node,
 child_node_iterator* child_iterator,
 size_t (*hash_function) (void*),
 int (*equals_function) (void*, void*))
 !child_iterator
 

share|improve this question

asked 10 mins ago

coderoddecoderodde

15.9k639129

share|improve this question

asked 10 mins ago

coderoddecoderodde

15.9k639129

asked 10 mins ago

coderoddecoderodde

15.9k639129

asked 10 mins ago

coderoddecoderodde

15.9k639129